[quant][fx] Remove should_insert_output_observers #74775
Conversation
Summary: We have simplified the way we insert observers, for add_scalar it now behaves the same way as general_tensor_value ops, which means we only need to keep is_general_tensor_value_op now, the other methods can be removed Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 77c0557 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
how does it work for add_scalar now? |
when there is one tensor input, output observer will share with input; when there are two tensor inputs, we'll create a new output observer |
Summary: Pull Request resolved: #74775 We have simplified the way we insert observers, for add_scalar it now behaves the same way as general_tensor_value ops, which means we only need to keep is_general_tensor_value_op now, the other methods can be removed Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Imported from OSS Reviewed By: vkuzo Differential Revision: D35153532 fbshipit-source-id: 2d17189e167a9932bdbf5ae46b3ced25b7128c2f
|
Hey @jerryzh168. |
Stack from ghstack (oldest at bottom):
Summary:
We have simplified the way we insert observers, for add_scalar it now behaves the same way
as general_tensor_value ops, which means we only need to keep is_general_tensor_value_op now,
the other methods can be removed
Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35153532