Skip to content

Adds dependencies on lazy codegen sources to invocation of generate_code #74750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wconstab wants to merge 1 commit into from
Closed

Adds dependencies on lazy codegen sources to invocation of generate_code #74750

wconstab wants to merge 1 commit into from

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Mar 25, 2022 •
edited
Loading

Isn't foolproof since it doesn't include transitive deps of these python scripts.

But without this change, any changes to lazy codegen .py files do not cause their generated output to be regenerated, making incremental development painful.

@wconstab
Adds dependencies on lazy codegen sources to invocation of generate_code
6da143a 
Isn't foolproof since it doesn't include transitive deps of these python scripts, but it's better than nothing.
@wconstab wconstab requested a review from bdhirsh March 25, 2022 16:02
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 6da143a (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

@wconstab has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Mar 25, 2022
@wconstab @facebook-github-bot
Adds dependencies on lazy codegen sources to invocation of generate_c…
5ef757f 
…ode (#74750)

Summary:
Isn't foolproof since it doesn't include transitive deps of these python scripts, but it's better than nothing.

Pull Request resolved: #74750

Reviewed By: bdhirsh

Differential Revision: D35145749

Pulled By: wconstab

fbshipit-source-id: ccd77cf18f68cc66c790f41f111833eca4101dac
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

Hey @wconstab.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@wconstab wconstab added topic: not user facing topic category release notes: lazy release notes category labels Mar 25, 2022
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
@github-actions github-actions bot deleted the wconstab/fix_codegen_deps branch February 15, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees

No one assigned

Labels

cla signed release notes: lazy release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wconstab @facebook-github-bot @bdhirsh