Fix Tensor.type(dtype) not preserving device #7474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that Tensor.cuda() will stil copy the tensor to the current device if it's a CUDA tensor on a different device. Fixes pytorch#7441
colesbury
requested review from
apaszke,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Member
Author
|
cc @ngimel |
gchanan
approved these changes
May 10, 2018
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
lgtm, nice that we aren't overloading -1 as much anymore.
onnxbot
added a commit
to onnxbot/onnx-fb-universe
that referenced
this pull request
May 10, 2018
weiyangfb
pushed a commit
to weiyangfb/pytorch
that referenced
this pull request
Jun 11, 2018
Note that Tensor.cuda() will stil copy the tensor to the current device if it's a CUDA tensor on a different device. Fixes pytorch#7441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that Tensor.cuda() will stil copy the tensor to the current device
if it's a CUDA tensor on a different device.
Fixes #7441