Skip to content

Make args work in the uru10x10_to_trt_eval script #74707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jerryzh168 wants to merge 1 commit into from
Closed

Make args work in the uru10x10_to_trt_eval script #74707

jerryzh168 wants to merge 1 commit into from

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Mar 24, 2022 •
edited
Loading

Summary:

Previously the _MinimizerSettingBase is getting arguments from argparse, and this disables any downstream projects from using argparse. this PR changes the class to a dataclass and rely on the init parameters to initialize the setting instead

Test Plan:

Meta-only test

Reviewed By: 842974287

Differential Revision: D34088069

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 9a084e2 (more details on the Dr. CI page):

  • 1/2 failures introduced in this PR
  • 1/2 broken upstream at merge base 11894db on Mar 24 from 12:09pm to 6:13pm

1 failure not recognized by patterns:

Job Step Action
GitHub Actions pull / linux-docs / build-docs (python) Unknown 🔁 rerun

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2022

This pull request was exported from Phabricator. Differential Revision: D34088069

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2022

This pull request was exported from Phabricator. Differential Revision: D34088069

@jerryzh168 @facebook-github-bot
Make args work in the uru10x10_to_trt_eval script (pytorch#74707)
9a084e2 
Summary:
Pull Request resolved: pytorch#74707

att

Test Plan:
```
buck run mode/dev-nosan -c fbcode.split-dwarf=true -c fbcode.platform=platform009 accelerators/workloads/models/uru10x10:uru_10x10_to_trt_eval -- -h
```

Reviewed By: 842974287

Differential Revision: D34088069

fbshipit-source-id: d25d98ca91aaf7e17dd4813adf65632aa3f1e86b
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2022

This pull request was exported from Phabricator. Differential Revision: D34088069

facebook-github-bot pushed a commit that referenced this pull request Mar 25, 2022
@jerryzh168 @facebook-github-bot
Make args work in the uru10x10_to_trt_eval script (#74707)
d9d79f0 
Summary:
Pull Request resolved: #74707

att

Test Plan:
```
buck run mode/dev-nosan -c fbcode.split-dwarf=true -c fbcode.platform=platform009 accelerators/workloads/models/uru10x10:uru_10x10_to_trt_eval -- -h
```

Reviewed By: 842974287

Differential Revision: D34088069

fbshipit-source-id: 5c89d25db6493e0f66f7e57aac24ed72196d0378
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

Hey @jerryzh168.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@jerryzh168 jerryzh168 added release notes: fx release notes category topic: improvements topic category labels Mar 25, 2022
shahofblah pushed a commit that referenced this pull request Mar 25, 2022
@jerryzh168 @shahofblah
Make args work in the uru10x10_to_trt_eval script (#74707)
72f5568 
Summary:
Pull Request resolved: #74707

att

Test Plan:
```
buck run mode/dev-nosan -c fbcode.split-dwarf=true -c fbcode.platform=platform009 accelerators/workloads/models/uru10x10:uru_10x10_to_trt_eval -- -h
```

Reviewed By: 842974287

Differential Revision: D34088069

fbshipit-source-id: 5c89d25db6493e0f66f7e57aac24ed72196d0378
(cherry picked from commit d9d79f0)
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed fb-exported module: fx release notes: fx release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jerryzh168 @facebook-github-bot