Skip to content

[PyTorch][deploy] Work around missing libdl #74705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
swolchok wants to merge 1 commit into from
Closed

[PyTorch][deploy] Work around missing libdl #74705

swolchok wants to merge 1 commit into from

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 24, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

As the comment says, libdl might not be separate because it may be subsumed into libc.

Differential Revision: D35117159

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

@swolchok
[PyTorch][deploy] Work around missing libdl
a4a8a38 
As the comment says, libdl might not be separate because it may be subsumed into libc.

Differential Revision: [D35117159](https://our.internmc.facebook.com/intern/diff/D35117159/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35117159/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit a4a8a38 (more details on the Dr. CI page):

  • 3/4 failures introduced in this PR
  • 1/4 broken upstream at merge base 9270bcc on Mar 24 from 7:29am to 3:17pm

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build pull / linux-docs / build-docs (cpp) (1/2)

Step: "Build cpp docs" (full log | diagnosis details | 🔁 rerun)

2022-03-24T21:08:52.5038042Z ImportError: canno...da/lib/python3.7/site-packages/jinja2/__init__.py) 
2022-03-24T21:08:52.5032425Z   File "/opt/conda/lib/python3.7/site-packages/sphinx/cmd/build.py", line 25, in <module>
2022-03-24T21:08:52.5032961Z     from sphinx.application import Sphinx
2022-03-24T21:08:52.5033612Z   File "/opt/conda/lib/python3.7/site-packages/sphinx/application.py", line 42, in <module>
2022-03-24T21:08:52.5034157Z     from sphinx.registry import SphinxComponentRegistry
2022-03-24T21:08:52.5034837Z   File "/opt/conda/lib/python3.7/site-packages/sphinx/registry.py", line 24, in <module>
2022-03-24T21:08:52.5035543Z     from sphinx.builders import Builder
2022-03-24T21:08:52.5036228Z   File "/opt/conda/lib/python3.7/site-packages/sphinx/builders/__init__.py", line 26, in <module>
2022-03-24T21:08:52.5036871Z     from sphinx.util import import_object, logging, rst, progress_message, status_iterator
2022-03-24T21:08:52.5037361Z   File "/opt/conda/lib/python3.7/site-packages/sphinx/util/rst.py", line 22, in <module>
2022-03-24T21:08:52.5037624Z     from jinja2 import environmentfilter
2022-03-24T21:08:52.5038042Z ImportError: cannot import name 'environmentfilter' from 'jinja2' (/opt/conda/lib/python3.7/site-packages/jinja2/__init__.py)
2022-03-24T21:08:52.5338208Z Makefile:27: recipe for target 'html' failed
2022-03-24T21:08:52.5338580Z make: *** [html] Error 1
2022-03-24T21:08:52.5379129Z ##[error]Process completed with exit code 2.
2022-03-24T21:08:52.5415445Z ##[group]Run pytorch/pytorch/.github/actions/chown-workspace@master
2022-03-24T21:08:52.5415688Z env:
2022-03-24T21:08:52.5415915Z   IN_CI: 1
2022-03-24T21:08:52.5416075Z   IS_GHA: 1
2022-03-24T21:08:52.5416240Z ##[endgroup]
2022-03-24T21:08:52.5429315Z ##[group]Run docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .
2022-03-24T21:08:52.5429657Z �[36;1mdocker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .�[0m

See GitHub Actions build pull / win-vs2019-cuda11.3-py3 / test (default, 2, 2, windows.8xlarge.nvidia.gpu) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-24T23:56:20.1381178Z RuntimeError: test_torch failed! 
2022-03-24T23:56:01.1910260Z Generated XML report: test-reports\dist-gloo\test_torch\TEST-TestVitalSignsCudaCUDA-20220324234607.xml
2022-03-24T23:56:01.1912138Z Generated XML report: test-reports\dist-gloo\test_torch\TEST-TestVitalSignsCudaCPU-20220324234607.xml
2022-03-24T23:56:18.9229080Z [TORCH_VITAL] CUDA.used		 true
2022-03-24T23:56:18.9229926Z [TORCH_VITAL] Dataloader.basic_unit_test		 TEST_VALUE_STRING
2022-03-24T23:56:18.9230727Z [TORCH_VITAL] Dataloader.enabled		 True
2022-03-24T23:56:20.1321122Z Traceback (most recent call last):
2022-03-24T23:56:20.1355601Z   File "run_test.py", line 1054, in <module>
2022-03-24T23:56:20.1356165Z     main()
2022-03-24T23:56:20.1357014Z   File "run_test.py", line 1032, in main
2022-03-24T23:56:20.1357631Z     raise RuntimeError(err_message)
2022-03-24T23:56:20.1381178Z RuntimeError: test_torch failed!
2022-03-24T23:56:23.4189942Z 
2022-03-24T23:56:23.4197090Z (base) C:\actions-runner\_work\pytorch\pytorch\test>popd
2022-03-24T23:56:23.4237517Z 
2022-03-24T23:56:23.4255299Z (base) C:\actions-runner\_work\pytorch\pytorch>if ERRORLEVEL 1 exit /b 1 
2022-03-24T23:56:23.5792444Z + cleanup
2022-03-24T23:56:23.5813920Z + retcode=1
2022-03-24T23:56:23.5814443Z + set +x
2022-03-24T23:56:23.6872039Z ##[error]Process completed with exit code 1.
2022-03-24T23:56:24.7157618Z ##[group]Run pytorch/pytorch/.github/actions/upload-test-artifacts@master
2022-03-24T23:56:24.7158490Z with:

1 failure not recognized by patterns:

Job Step Action
GitHub Actions pull / linux-docs / build-docs (python) Unknown 🔁 rerun

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

swolchok added a commit that referenced this pull request Mar 24, 2022
@swolchok
[PyTorch][deploy] Work around missing libdl
5df4bc2 
As the comment says, libdl might not be separate because it may be subsumed into libc.

Differential Revision: [D35117159](https://our.internmc.facebook.com/intern/diff/D35117159/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35117159/)!

ghstack-source-id: 152156345
Pull Request resolved: #74705
facebook-github-bot pushed a commit that referenced this pull request Mar 25, 2022
@swolchok @facebook-github-bot
[PyTorch][deploy] Work around missing libdl (#74705)
563919d 
Summary:
Pull Request resolved: #74705

As the comment says, libdl might not be separate because it may be subsumed into libc.

Test Plan:
1) existing tests
2) this is being sent out on top of platform010 migration for caffe2

Reviewed By: d4l3k, r-barnes

Differential Revision: D35117159

fbshipit-source-id: c4a6de7c3412db695509bd25d529658cdf785e3d
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

Hey @swolchok.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

shahofblah pushed a commit that referenced this pull request Mar 25, 2022
@swolchok @shahofblah
[PyTorch][deploy] Work around missing libdl (#74705)
dc7cc23 
Summary:
Pull Request resolved: #74705

As the comment says, libdl might not be separate because it may be subsumed into libc.

Test Plan:
1) existing tests
2) this is being sent out on top of platform010 migration for caffe2

Reviewed By: d4l3k, r-barnes

Differential Revision: D35117159

fbshipit-source-id: c4a6de7c3412db695509bd25d529658cdf785e3d
(cherry picked from commit 563919d)
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/476/head branch March 28, 2022 14:17
@swolchok swolchok added the topic: not user facing topic category label Mar 29, 2022
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @facebook-github-bot