Skip to content

Automatically extern C extension modules in torch.package #74702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
syeehyn wants to merge 1 commit into from
Closed

Automatically extern C extension modules in torch.package #74702

syeehyn wants to merge 1 commit into from

Conversation

@syeehyn
Copy link

@syeehyn syeehyn commented Mar 24, 2022 •
edited
Loading

Summary:

  • add flag in constructor.
  • add if condition routing to extern c-extension in method _intern_module.
  • add unit test for the new condition.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 23dfb00 (more details on the Dr. CI page):

  • 3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build pull / win-vs2019-cuda11.3-py3 / test (force_on_cpu, 1, 1, windows.4xlarge) (1/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-25T22:45:23.7226760Z RuntimeError: test_package failed! 
2022-03-25T22:45:23.5348760Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_repackage.TestRepackage-20220325224522.xml
2022-03-25T22:45:23.5350029Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_resources.TestResources-20220325224522.xml
2022-03-25T22:45:23.5351192Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_save_load.TestSaveLoad-20220325224522.xml
2022-03-25T22:45:23.5352474Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_directory_reader.DirectoryReaderTest-20220325224522.xml
2022-03-25T22:45:23.5353701Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_model.ModelTest-20220325224522.xml
2022-03-25T22:45:23.7224355Z Traceback (most recent call last):
2022-03-25T22:45:23.7225126Z   File "run_test.py", line 1054, in <module>
2022-03-25T22:45:23.7225469Z     main()
2022-03-25T22:45:23.7225898Z   File "run_test.py", line 1032, in main
2022-03-25T22:45:23.7226313Z     raise RuntimeError(err_message)
2022-03-25T22:45:23.7226760Z RuntimeError: test_package failed!
2022-03-25T22:45:23.9657240Z 
2022-03-25T22:45:23.9657958Z (base) C:\actions-runner\_work\pytorch\pytorch\test>popd
2022-03-25T22:45:23.9661766Z 
2022-03-25T22:45:23.9662419Z (base) C:\actions-runner\_work\pytorch\pytorch>if ERRORLEVEL 1 exit /b 1 
2022-03-25T22:45:23.9688525Z + cleanup
2022-03-25T22:45:23.9688856Z + retcode=1
2022-03-25T22:45:23.9689121Z + set +x
2022-03-25T22:45:23.9718260Z ##[error]Process completed with exit code 1.
2022-03-25T22:45:24.0146972Z ##[group]Run pytorch/pytorch/.github/actions/upload-test-artifacts@master
2022-03-25T22:45:24.0147525Z with:

See GitHub Actions build pull / win-vs2019-cpu-py3 / test (default, 2, 2, windows.4xlarge) (2/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-25T21:58:21.7828548Z RuntimeError: test_package failed! 
2022-03-25T21:58:21.6058728Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_repackage.TestRepackage-20220325215820.xml
2022-03-25T21:58:21.6060010Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_resources.TestResources-20220325215820.xml
2022-03-25T21:58:21.6061231Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_save_load.TestSaveLoad-20220325215820.xml
2022-03-25T21:58:21.6062542Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_directory_reader.DirectoryReaderTest-20220325215820.xml
2022-03-25T21:58:21.6063807Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_model.ModelTest-20220325215820.xml
2022-03-25T21:58:21.7825937Z Traceback (most recent call last):
2022-03-25T21:58:21.7826814Z   File "run_test.py", line 1054, in <module>
2022-03-25T21:58:21.7827187Z     main()
2022-03-25T21:58:21.7827659Z   File "run_test.py", line 1032, in main
2022-03-25T21:58:21.7828097Z     raise RuntimeError(err_message)
2022-03-25T21:58:21.7828548Z RuntimeError: test_package failed!
2022-03-25T21:58:22.0027607Z 
2022-03-25T21:58:22.0028189Z (base) C:\actions-runner\_work\pytorch\pytorch\test>popd
2022-03-25T21:58:22.0032118Z 
2022-03-25T21:58:22.0032613Z (base) C:\actions-runner\_work\pytorch\pytorch>if ERRORLEVEL 1 exit /b 1 
2022-03-25T21:58:22.0057418Z + cleanup
2022-03-25T21:58:22.0057749Z + retcode=1
2022-03-25T21:58:22.0058192Z + set +x
2022-03-25T21:58:22.0087789Z ##[error]Process completed with exit code 1.
2022-03-25T21:58:22.0443457Z ##[group]Run pytorch/pytorch/.github/actions/upload-test-artifacts@master
2022-03-25T21:58:22.0444024Z with:

See GitHub Actions build pull / win-vs2019-cuda11.3-py3 / test (default, 2, 2, windows.8xlarge.nvidia.gpu) (3/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-25T23:42:43.3858365Z RuntimeError: test_package failed! 
2022-03-25T23:42:43.0151719Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_repackage.TestRepackage-20220325234241.xml
2022-03-25T23:42:43.0153451Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_resources.TestResources-20220325234241.xml
2022-03-25T23:42:43.0155062Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_save_load.TestSaveLoad-20220325234241.xml
2022-03-25T23:42:43.0156973Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_directory_reader.DirectoryReaderTest-20220325234241.xml
2022-03-25T23:42:43.0158690Z Generated XML report: test-reports\dist-gloo\test_package\TEST-test_model.ModelTest-20220325234241.xml
2022-03-25T23:42:43.3855031Z Traceback (most recent call last):
2022-03-25T23:42:43.3856097Z   File "run_test.py", line 1054, in <module>
2022-03-25T23:42:43.3856579Z     main()
2022-03-25T23:42:43.3857185Z   File "run_test.py", line 1032, in main
2022-03-25T23:42:43.3857774Z     raise RuntimeError(err_message)
2022-03-25T23:42:43.3858365Z RuntimeError: test_package failed!
2022-03-25T23:42:43.7689275Z 
2022-03-25T23:42:43.7690664Z (base) C:\actions-runner\_work\pytorch\pytorch\test>popd
2022-03-25T23:42:43.7697989Z 
2022-03-25T23:42:43.7698813Z (base) C:\actions-runner\_work\pytorch\pytorch>if ERRORLEVEL 1 exit /b 1 
2022-03-25T23:42:43.7733763Z + cleanup
2022-03-25T23:42:43.7734536Z + retcode=1
2022-03-25T23:42:43.7735185Z + set +x
2022-03-25T23:42:43.7770787Z ##[error]Process completed with exit code 1.
2022-03-25T23:42:43.8428518Z ##[group]Run pytorch/pytorch/.github/actions/upload-test-artifacts@master
2022-03-25T23:42:43.8429357Z with:
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

@facebook-github-bot
Automatically extern C extension modules in torch.package (pytorch#74702
23dfb00 
)

Summary:
Pull Request resolved: pytorch#74702

- add flag in constructor.
- add if condition routing to extern c-extension in method `_intern_module`.
- add unit test for the new condition.

Test Plan: Imported from OSS

Reviewed By: PaliC

Differential Revision: D35124731

fbshipit-source-id: 6b1a771d47216cf3cde986b179232d82b30a225d
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2022

This pull request was exported from Phabricator. Differential Revision: D35124731

facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2022
@facebook-github-bot
Automatically extern C extension modules in torch.package (#74702)
57239a7 
Summary:
Pull Request resolved: #74702

- add flag in constructor.
- add if condition routing to extern c-extension in method `_intern_module`.
- add unit test for the new condition.

Test Plan: Imported from OSS

Reviewed By: PaliC

Differential Revision: D35124731

fbshipit-source-id: a4b7fdf3210e0ad4bfd1ea30fd94595d10405987
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 28, 2022

This pull request has been reverted by 58f78ff. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2022

This pull request has been reverted by 58f78ff. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

@zengk95 zengk95 mentioned this pull request Apr 5, 2022
Closed
@syeehyn syeehyn mentioned this pull request Apr 7, 2022
Closed
syeehyn pushed a commit to syeehyn/pytorch that referenced this pull request Apr 7, 2022
@facebook-github-bot
Automatically extern C extension modules in torch.package (pytorch#74702
a2ac76b 
)

Summary:
Pull Request resolved: pytorch#74702
- add flag in constructor.
- add if condition routing to extern c-extension in method _intern_module.
- add unit test for the new condition.

Test Plan: Added test case in `test_dependency_api.py`

Differential Revision: D35456204

fbshipit-source-id: d637aeb8e523ffff711158518c822b7e74287d00
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed fb-exported Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syeehyn @facebook-github-bot