[PyTorch] Delete NestedTensor Python wrapper #74691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapper just called through to methods on the underlying Tensor. Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/) [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8b3a629 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
swolchok
added a commit
that referenced
this pull request
Mar 24, 2022
The wrapper just called through to methods on the underlying Tensor. Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/) ghstack-source-id: 152119329 Pull Request resolved: #74691
The wrapper just called through to methods on the underlying Tensor. Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 24, 2022
Pull Request resolved: #74691 The wrapper just called through to methods on the underlying Tensor. ghstack-source-id: 152147833 Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/)
The wrapper just called through to methods on the underlying Tensor. Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 24, 2022
Pull Request resolved: #74691 The wrapper just called through to methods on the underlying Tensor. ghstack-source-id: 152159577 Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/)
The wrapper just called through to methods on the underlying Tensor. Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 25, 2022
Pull Request resolved: #74691 The wrapper just called through to methods on the underlying Tensor. ghstack-source-id: 152223291 Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/)
The wrapper just called through to methods on the underlying Tensor. Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 28, 2022
Pull Request resolved: #74691 The wrapper just called through to methods on the underlying Tensor. ghstack-source-id: 152399357 Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/)
The wrapper just called through to methods on the underlying Tensor. Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 29, 2022
Pull Request resolved: #74691 The wrapper just called through to methods on the underlying Tensor. ghstack-source-id: 152433754 Differential Revision: [D34689789](https://our.internmc.facebook.com/intern/diff/D34689789/)
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
Summary: Pull Request resolved: #74691 The wrapper just called through to methods on the underlying Tensor. ghstack-source-id: 152433754 Test Plan: existing tests Reviewed By: ezyang Differential Revision: D34689789 fbshipit-source-id: cf53476780cf3ed00a3aa4add441300bfe8e27ce
|
Now that the wrapper is deleted is there any way to distinguish between a nested tensor and a regular tensor? Currently I have two work arounds: try:
tensor.shape
is_nested = False
except RuntimeError as ex:
is_nested = "NestedTensorImpl" in str(ex)or is_nested = "nested_tensor" in str(tensor)The former is very slow because of the try except perfomace. The latter requires a copy to the CPU for the print. |
Contributor
|
@mattangus - I agree that we should have something here. Could I kindly ask you to open a separate issue? Also, as a user of this new prototype feature maybe you want to share more what your use case is and what you have planned for NestedTensor? |
Contributor
Author
|
#73999 added Tensor.is_nested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The wrapper just called through to methods on the underlying Tensor.
Differential Revision: D34689789