[PyTorch] Only select root ops in codegen unboxing #74663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5585405 (more details on the Dr. CI page):
1 failure not recognized by patterns:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
facebook-github-bot
added
oncall: jit
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35104401 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35104401 |
larryliu0820
force-pushed
the
export-D35104401
branch
from
a8043e1 to
e7c825d
Compare
…ch (pytorch#74664) Summary: This change adds the following logic: If lightweight dispatch is enabled, do not generate `TORCH_LIBARAY` API calls for operator schema and implementations, since these operators will be registered into JIT op registry. `skip_dispatcher_op_registration` is an existing argument to `gen.py`. With that set, `RegisterDispatchKey.cpp` will not generate `m.def` and `m.impl` for each native function. This logic will be removed once we find a better way to skip op registration into dispatcher. Pull Request resolved: pytorch#74664 Test Plan: Rely on unit tests for lightweight dispatch. Reviewed By: priyaramani Differential Revision: D34634300 Pulled By: larryliu0820 fbshipit-source-id: 2882b96b30c8e6edadb6efa065c6310747cc08dc
Summary: Pull Request resolved: pytorch#74663 In lightweight dispatch, we only need to register root ops. Unlike in the dispatcher world, the transitive closure of the operators doesn't need to go through dispatcher or op registry. Test Plan: Rely on unit tests Reviewed By: priyaramani Differential Revision: D35104401 fbshipit-source-id: c5e9d64b866d92135a11cad2f10adb63701edda7
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35104401 |
larryliu0820
force-pushed
the
export-D35104401
branch
from
e7c825d to
5585405
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #74663 In lightweight dispatch, we only need to register root ops. Unlike in the dispatcher world, the transitive closure of the operators doesn't need to go through dispatcher or op registry. Test Plan: Rely on unit tests Reviewed By: priyaramani Differential Revision: D35104401 fbshipit-source-id: 1a2df571880ac3c8625985c01bd89a2bb9566af9
Contributor
|
Hey @larryliu0820. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #74663 In lightweight dispatch, we only need to register root ops. Unlike in the dispatcher world, the transitive closure of the operators doesn't need to go through dispatcher or op registry. Test Plan: Rely on unit tests Reviewed By: priyaramani Differential Revision: D35104401 fbshipit-source-id: 1a2df571880ac3c8625985c01bd89a2bb9566af9 (cherry picked from commit 16207fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In lightweight dispatch, we only need to register root ops. Unlike in the dispatcher world, the transitive closure of the operators doesn't need to go through dispatcher or op registry.
Test Plan: Rely on unit tests
Differential Revision: D35104401