Composite Compliance testing for backward formulas #74646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpInfo-based test, given an operator and sample inputs,
checks all permutations of {inputs, grad_output} being either
{CompositeCompliantTensor, regular Tensor}, running them through a
forward pass and a backward pass.
Test Plan:
- wait for tests
[ghstack-poisoned]
This was referenced Mar 23, 2022
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 342653f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zou3519
added a commit
that referenced
this pull request
Mar 23, 2022
The OpInfo-based test, given an operator and sample inputs,
checks all permutations of {inputs, grad_output} being either
{CompositeCompliantTensor, regular Tensor}, running them through a
forward pass and a backward pass.
Test Plan:
- wait for tests
ghstack-source-id: 903f52c
Pull Request resolved: #74646
Contributor
Author
|
Pre-empting questions about runtime:
I think this qualifies as "quick enough that the benefits outweigh the cost" but please feel free to disagree. If we're really pressed on capacity, this test only really needs to run in one CI environment configuration |
The OpInfo-based test, given an operator and sample inputs,
checks all permutations of {inputs, grad_output} being either
{CompositeCompliantTensor, regular Tensor}, running them through a
forward pass and a backward pass.
Test Plan:
- wait for tests
[ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Mar 25, 2022
The OpInfo-based test, given an operator and sample inputs,
checks all permutations of {inputs, grad_output} being either
{CompositeCompliantTensor, regular Tensor}, running them through a
forward pass and a backward pass.
Test Plan:
- wait for tests
ghstack-source-id: ee6e420
Pull Request resolved: #74646
zou3519
commented
Mar 25, 2022
| return | ||
| raise RuntimeError( | ||
| f"This operator is not CompositeImplicitAutograd compliant: the " | ||
| f"This operator is not Composite Compliant: the " |
Contributor
Author
There was a problem hiding this comment.
Name change because "CompositeImplicitAutograd" only applies to operators and many backward formulas are just regular c++ functions that consist of pytorch operations
ezyang
reviewed
Mar 26, 2022
|
|
||
| # CompositeCompliantTensor steals the "requires_grad"-ness. | ||
| if elem.requires_grad: | ||
| # Why clone? Because sometimes OpInfo shares inputs between tests... |
ezyang
approved these changes
Mar 26, 2022
The OpInfo-based test, given an operator and sample inputs,
checks all permutations of {inputs, grad_output} being either
{CompositeCompliantTensor, regular Tensor}, running them through a
forward pass and a backward pass.
Test Plan:
- wait for tests
[ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Mar 28, 2022
The OpInfo-based test, given an operator and sample inputs,
checks all permutations of {inputs, grad_output} being either
{CompositeCompliantTensor, regular Tensor}, running them through a
forward pass and a backward pass.
Test Plan:
- wait for tests
ghstack-source-id: 9d2e1e0
Pull Request resolved: #74646
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
Summary: Pull Request resolved: #74646 The OpInfo-based test, given an operator and sample inputs, checks all permutations of {inputs, grad_output} being either {CompositeCompliantTensor, regular Tensor}, running them through a forward pass and a backward pass. Test Plan: - wait for tests Reviewed By: albanD Differential Revision: D35186860 Pulled By: zou3519 fbshipit-source-id: 8b2577dd6106c05db2ab583bbefd10545fdd8adf
Contributor
|
Hey @zou3519. |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 19, 2022
Follow up to #74646. Do not skip the entire TestCompositeCompliance test_backward for ROCm, only skip the the two unexpected successes. Pull Request resolved: #75810 Approved by: https://github.com/zou3519
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
Summary: Follow up to #74646. Do not skip the entire TestCompositeCompliance test_backward for ROCm, only skip the the two unexpected successes. Pull Request resolved: #75810 Approved by: https://github.com/zou3519 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e587c8bc5782510c7e518c8db8663014ac5e063f Reviewed By: seemethere Differential Revision: D35751446 fbshipit-source-id: e5cae9bf19d46572cc360d9fb4cb87642e5960d3
malfet
pushed a commit
that referenced
this pull request
Apr 20, 2022
Follow up to #74646. Do not skip the entire TestCompositeCompliance test_backward for ROCm, only skip the the two unexpected successes. Pull Request resolved: #75810 Approved by: https://github.com/zou3519 (cherry picked from commit e587c8b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The OpInfo-based test, given an operator and sample inputs,
checks all permutations of {inputs, grad_output} being either
{CompositeCompliantTensor, regular Tensor}, running them through a
forward pass and a backward pass.
Test Plan:
Differential Revision: D35186860