Skip to content

Allow torch/csrc/deploy/interpreter/Optional.hpp to be allowed into the wheel distribution #74643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PaliC wants to merge 2 commits into from
Closed

Allow torch/csrc/deploy/interpreter/Optional.hpp to be allowed into the wheel distribution #74643

PaliC wants to merge 2 commits into from

Conversation

@PaliC
Copy link
Contributor

@PaliC PaliC commented Mar 23, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Previously torch/csrc/deploy/interpreter/Optional.hpp wasn't getting included in the wheel distribution created by USE_DEPLOY=1 python setup.py bdist_wheel, this pr fixes that

Differential Revision: D35094459

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 23, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 4a14968 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See GitHub Actions build pull / linux-xenial-py3.7-clang7-onnx / test (default, 1, 2, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

2022-03-23T22:58:13.1470182Z �[1m�[31mE ...the first call but did not on a subsequent one�[0m 
2022-03-23T22:58:13.1464681Z �[1m�[31m/opt/conda/lib/python3.7/site-packages/hypothesis/core.py�[0m:606: in execute
2022-03-23T22:58:13.1465693Z     ) % (test.__name__, text_repr[0],))
2022-03-23T22:58:13.1466065Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
2022-03-23T22:58:13.1466274Z 
2022-03-23T22:58:13.1466601Z self = <hypothesis.core.StateForActualGivenExecution object at 0x7fb288d57e10>
2022-03-23T22:58:13.1467538Z message = 'Hypothesis test_allcompare(self=<caffe2.python.allcompare_test.TestAllCompare testMethod=test_allcompare>, d=2, n=5, num_procs=6) produces unreliable results: Falsified on the first call but did not on a subsequent one'
2022-03-23T22:58:13.1468143Z 
2022-03-23T22:58:13.1468359Z     def __flaky(self, message):
2022-03-23T22:58:13.1468690Z         if len(self.falsifying_examples) <= 1:
2022-03-23T22:58:13.1469161Z >           raise Flaky(message)
2022-03-23T22:58:13.1470182Z �[1m�[31mE           hypothesis.errors.Flaky: Hypothesis test_allcompare(self=<caffe2.python.allcompare_test.TestAllCompare testMethod=test_allcompare>, d=2, n=5, num_procs=6) produces unreliable results: Falsified on the first call but did not on a subsequent one�[0m
2022-03-23T22:58:13.1471019Z 
2022-03-23T22:58:13.1471392Z �[1m�[31m/opt/conda/lib/python3.7/site-packages/hypothesis/core.py�[0m:877: Flaky
2022-03-23T22:58:13.1471967Z ----------------------------- Captured stdout call -----------------------------
2022-03-23T22:58:13.1472421Z Ignoring @/caffe2/caffe2/distributed:file_store_handler_ops as it is not a valid file.
2022-03-23T22:58:13.1472952Z Ignoring @/caffe2/caffe2/distributed:file_store_handler_ops as it is not a valid file.
2022-03-23T22:58:13.1473370Z Ignoring @/caffe2/caffe2/distributed:file_store_handler_ops as it is not a valid file.
2022-03-23T22:58:13.1473809Z Ignoring @/caffe2/caffe2/distributed:file_store_handler_ops as it is not a valid file.
2022-03-23T22:58:13.1474293Z Ignoring @/caffe2/caffe2/distributed:file_store_handler_ops as it is not a valid file.
2022-03-23T22:58:13.1474685Z Ignoring @/caffe2/caffe2/distributed:file_store_handler_ops as it is not a valid file.
2022-03-23T22:58:13.1475037Z Ignoring @/caffe2/caffe2/distributed:file_store_handler_ops as it is not a valid file.

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@PaliC PaliC requested review from aivanou, d4l3k and kiukchung March 23, 2022 21:44
@PaliC
Update on "Allow torch/csrc/deploy/interpreter/Optional.hpp to be all…
4a14968 
…owed into the wheel distribution"

[ghstack-poisoned]
PaliC added a commit that referenced this pull request Mar 23, 2022
@PaliC
Allow torch/csrc/deploy/interpreter/Optional.hpp to be allowed into t…
67207d9 
…he wheel distribution

ghstack-source-id: fa352b6
Pull Request resolved: #74643
@PaliC
Copy link
Contributor Author

PaliC commented Mar 23, 2022

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Mar 24, 2022
@PaliC @facebook-github-bot
Allow torch/csrc/deploy/interpreter/Optional.hpp to be allowed into t…
6ad5d96 
…he wheel distribution (#74643)

Summary:
Pull Request resolved: #74643

Previously `torch/csrc/deploy/interpreter/Optional.hpp` wasn't getting included in the wheel distribution created by `USE_DEPLOY=1 python setup.py bdist_wheel`, this pr fixes that

Test Plan: Imported from OSS

Reviewed By: d4l3k

Differential Revision: D35094459

Pulled By: PaliC

fbshipit-source-id: 50aea946cc5bb72720b993075bd57ccf8377db30
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2022

Hey @PaliC.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

shahofblah pushed a commit that referenced this pull request Mar 25, 2022
@PaliC @shahofblah
Allow torch/csrc/deploy/interpreter/Optional.hpp to be allowed into t…
c38f04d 
…he wheel distribution (#74643)

Summary:
Pull Request resolved: #74643

Previously `torch/csrc/deploy/interpreter/Optional.hpp` wasn't getting included in the wheel distribution created by `USE_DEPLOY=1 python setup.py bdist_wheel`, this pr fixes that

Test Plan: Imported from OSS

Reviewed By: d4l3k

Differential Revision: D35094459

Pulled By: PaliC

fbshipit-source-id: 50aea946cc5bb72720b993075bd57ccf8377db30
(cherry picked from commit 6ad5d96)
@facebook-github-bot facebook-github-bot deleted the gh/PaliC/150/head branch March 27, 2022 14:17
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

@aivanou aivanou Awaiting requested review from aivanou

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PaliC @facebook-github-bot