c10d: retry dns lookup failures #74641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4l3k
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit db8033b (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
facebook-github-bot
added
fb-exported
oncall: distributed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35092284 |
Summary: Pull Request resolved: pytorch#74641 This makes dns hostname lookup failures retryable since in some environments such as Kubernetes they're not guaranteed to be resolvable until the job starts. Retrying this eliminates the race condition. This also fixes `sandcastle_skip_if` when used on the class instead of the method. Previously they wouldn't inherit from TestCase so just wouldn't run under buck at all. Fixes pytorch#73682 Test Plan: Added a unit test ``` buck test //caffe2/test/distributed:test_store ``` Reviewed By: aivanou Differential Revision: D35092284 fbshipit-source-id: ab067f08a2cff6d6d7a17d3f1267226cb2f9293b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35092284 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
Summary: Pull Request resolved: #74641 This makes dns hostname lookup failures retryable since in some environments such as Kubernetes they're not guaranteed to be resolvable until the job starts. Retrying this eliminates the race condition. This also fixes `sandcastle_skip_if` when used on the class instead of the method. Previously they wouldn't inherit from TestCase so just wouldn't run under buck at all. Fixes #73682 Test Plan: Added a unit test ``` buck test //caffe2/test/distributed:test_store ``` Reviewed By: aivanou Differential Revision: D35092284 fbshipit-source-id: d40bf187e52c41f551e4fe41c536b2b0015588ee
Contributor
|
Hey @d4l3k. |
d4l3k
added
release notes: distributed (c10d)
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #74641 This makes dns hostname lookup failures retryable since in some environments such as Kubernetes they're not guaranteed to be resolvable until the job starts. Retrying this eliminates the race condition. This also fixes `sandcastle_skip_if` when used on the class instead of the method. Previously they wouldn't inherit from TestCase so just wouldn't run under buck at all. Fixes #73682 Test Plan: Added a unit test ``` buck test //caffe2/test/distributed:test_store ``` Reviewed By: aivanou Differential Revision: D35092284 fbshipit-source-id: d40bf187e52c41f551e4fe41c536b2b0015588ee (cherry picked from commit f890830)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This makes dns hostname lookup failures retryable since in some environments such as Kubernetes they're not guaranteed to be resolvable until the job starts. Retrying this eliminates the race condition.
Fixes #73682
Test Plan:
Added a unit test
Reviewed By: aivanou
Differential Revision: D35092284