[Quant][fx] Refactor lowering code (part 2) #74619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This commit is part 2 of the effort to refactor the lowering code in _lower_to_native_backend.py. The main change included in this commit is generalizing the pattern matching code across different lowering functions. There should be no change in behavior with this PR. A future commit will further merge the static and dynamic lowering code paths. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: jerryzh168 Subscribers: jerryzh168 [ghstack-poisoned]
andrewor14
added
release notes: quantization
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit f9cc7ca (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
Author
|
@andrewor14 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
reviewed
Mar 23, 2022
jerryzh168
approved these changes
Mar 23, 2022
andrewor14
added a commit
that referenced
this pull request
Mar 23, 2022
Summary: This commit is part 2 of the effort to refactor the lowering code in _lower_to_native_backend.py. The main change included in this commit is generalizing the pattern matching code across different lowering functions. There should be no change in behavior with this PR. A future commit will further merge the static and dynamic lowering code paths. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: jerryzh168 Subscribers: jerryzh168 ghstack-source-id: 6b75ab0 Pull Request resolved: #74619
Summary: This commit is part 2 of the effort to refactor the lowering code in _lower_to_native_backend.py. The main change included in this commit is generalizing the pattern matching code across different lowering functions. There should be no change in behavior with this PR. A future commit will further merge the static and dynamic lowering code paths. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: jerryzh168 Subscribers: jerryzh168 Differential Revision: [D35082210](https://our.internmc.facebook.com/intern/diff/D35082210) [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Mar 23, 2022
Summary: This commit is part 2 of the effort to refactor the lowering code in _lower_to_native_backend.py. The main change included in this commit is generalizing the pattern matching code across different lowering functions. There should be no change in behavior with this PR. A future commit will further merge the static and dynamic lowering code paths. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: jerryzh168 Subscribers: jerryzh168 ghstack-source-id: eb885a5 Pull Request resolved: #74619
Contributor
Author
|
@andrewor14 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
Summary: Pull Request resolved: #74619 This commit is part 2 of the effort to refactor the lowering code in _lower_to_native_backend.py. The main change included in this commit is generalizing the pattern matching code across different lowering functions. There should be no change in behavior with this PR. A future commit will further merge the static and dynamic lowering code paths. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Imported from OSS Reviewed By: jerryzh168 Differential Revision: D35082210 fbshipit-source-id: 7f0347c9449cc9ca68fee5a807c792222f0d1749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: This commit is part 2 of the effort to refactor the
lowering code in _lower_to_native_backend.py. The main change
included in this commit is generalizing the pattern matching
code across different lowering functions. There should be no
change in behavior with this PR.
A future commit will further merge the static and dynamic
lowering code paths.
Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
Reviewers: jerryzh168
Subscribers: jerryzh168
Differential Revision: D35082210