Skip to content

Create jiterator cache dirs recursively (reland) #74592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 2 commits into from
Closed

Create jiterator cache dirs recursively (reland) #74592

malfet wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Mar 23, 2022

Reland of #74425 with internal compilation error fixed

The change expects the base directories (HOME/TEMP, XDG_CACHE_HOME, or the user-defined PYTORCH_KERNEL_CACHE_PATH) to exist to avoid potentially exploiting the recursive folder creation.

ptrblck and others added 2 commits March 22, 2022 16:05
@ptrblck @malfet
Create jiterator cache dirs recursively
e7fcf99 
Fixes #74415

@mruberry
The change expects the base directories (`HOME/TEMP`, `XDG_CACHE_HOME`, or the user-defined `PYTORCH_KERNEL_CACHE_PATH`) to exist to avoid potentially exploiting the recursive folder creation.
Let me know, if this is not a concern from your side and this PR should be simplified.
Pull Request resolved: #74425
Approved by: https://github.com/mruberry
@malfet
Fix compilation warning
cb8ee91
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 23, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit cb8ee91 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet mentioned this pull request Mar 23, 2022
Closed
@malfet malfet requested review from mruberry and ngimel March 23, 2022 00:41
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 23, 2022

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mruberry
mruberry approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped

facebook-github-bot pushed a commit that referenced this pull request Mar 23, 2022
@malfet @facebook-github-bot
Create jiterator cache dirs recursively (reland) (#74592)
99479e5 
Summary:
Reland of #74425 with internal compilation error fixed

The change expects the base directories (`HOME/TEMP`, `XDG_CACHE_HOME`, or the user-defined `PYTORCH_KERNEL_CACHE_PATH`) to exist to avoid potentially exploiting the recursive folder creation.

Pull Request resolved: #74592

Reviewed By: mruberry

Differential Revision: D35066710

Pulled By: malfet

fbshipit-source-id: c26aff826b0a3d6ca99286b031711698a515fbbb
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@malfet malfet added release notes: cuda release notes category topic: bug fixes topic category labels Mar 23, 2022
shahofblah pushed a commit that referenced this pull request Mar 25, 2022
@malfet @shahofblah
Create jiterator cache dirs recursively (reland) (#74592)
87a513f 
Summary:
Reland of #74425 with internal compilation error fixed

The change expects the base directories (`HOME/TEMP`, `XDG_CACHE_HOME`, or the user-defined `PYTORCH_KERNEL_CACHE_PATH`) to exist to avoid potentially exploiting the recursive folder creation.

Pull Request resolved: #74592

Reviewed By: mruberry

Differential Revision: D35066710

Pulled By: malfet

fbshipit-source-id: c26aff826b0a3d6ca99286b031711698a515fbbb
(cherry picked from commit 99479e5)
@malfet malfet deleted the malfet/reland-74425 branch July 17, 2022 18:13
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

cla signed release notes: cuda release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @facebook-github-bot @mruberry @ptrblck