remove unused nn_path from generate_code #74563

dagitses · 2022-03-22T18:08:32Z

Stack from ghstack (oldest at bottom):

This is used inconsistently in all the generate_code program
invocations. Nevertheless, nothing consumes this flag, so we can
safely remove it.

This was removed in #25353.

Differential Revision: D35053096

This is used inconsistently in all the generate_code program invocations. Nevertheless, nothing consumes this flag, so we can safely remove it. This was removed in #25353. Differential Revision: [D35053096](https://our.internmc.facebook.com/intern/diff/D35053096/) [ghstack-poisoned]

facebook-github-bot · 2022-03-22T18:08:54Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/74563
↩️ [fb-only] Re-run with SSH instructions
Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit b4c9f8c (more details on the Dr. CI page):

4/4 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T19:27:44.3804463Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m

2022-03-30T19:27:44.3801573Z �[36;1mfi�[0m
2022-03-30T19:27:44.3801805Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T19:27:44.3802149Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T19:27:44.3802468Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T19:27:44.3802813Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T19:27:44.3803094Z �[36;1m  exit 1�[0m
2022-03-30T19:27:44.3803263Z �[36;1mfi�[0m
2022-03-30T19:27:44.3803487Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T19:27:44.3803821Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T19:27:44.3804131Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T19:27:44.3804463Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T19:27:44.3804863Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T19:27:44.3805096Z �[36;1m  exit 1�[0m
2022-03-30T19:27:44.3805265Z �[36;1mfi�[0m
2022-03-30T19:27:44.3805449Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T19:27:44.3816305Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T19:27:44.3816527Z env:
2022-03-30T19:27:44.3816675Z   IN_CI: 1
2022-03-30T19:27:44.3816837Z   IS_GHA: 1
2022-03-30T19:27:44.3817018Z   GIT_DEFAULT_BRANCH: master
2022-03-30T19:27:44.3817242Z   BASE_REVISION: 41a4e4ea94b602966ecf1eca2f807542d72b3a67

pull / linux-xenial-cuda11.3-py3.7-gcc7 / build (2/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T19:27:45.0128047Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m

2022-03-30T19:27:45.0107061Z �[36;1mfi�[0m
2022-03-30T19:27:45.0107288Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T19:27:45.0107625Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T19:27:45.0107936Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T19:27:45.0108277Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T19:27:45.0108553Z �[36;1m  exit 1�[0m
2022-03-30T19:27:45.0108712Z �[36;1mfi�[0m
2022-03-30T19:27:45.0108930Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T19:27:45.0109257Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T19:27:45.0109562Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T19:27:45.0128047Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T19:27:45.0128569Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T19:27:45.0129036Z �[36;1m  exit 1�[0m
2022-03-30T19:27:45.0129276Z �[36;1mfi�[0m
2022-03-30T19:27:45.0129466Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T19:27:45.0140106Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T19:27:45.0140324Z env:
2022-03-30T19:27:45.0140470Z   IN_CI: 1
2022-03-30T19:27:45.0140632Z   IS_GHA: 1
2022-03-30T19:27:45.0140850Z   BASE_REVISION: 41a4e4ea94b602966ecf1eca2f807542d72b3a67
2022-03-30T19:27:45.0141255Z   DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7:a2c09c6009bb8a10cbb45a8c5f7c573593289be0

pull / deploy-linux-xenial-cuda11.3-py3.7-gcc7 / build (3/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T19:23:25.3039027Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m

2022-03-30T19:23:25.3036047Z �[36;1mfi�[0m
2022-03-30T19:23:25.3036282Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T19:23:25.3036626Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T19:23:25.3036937Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T19:23:25.3037271Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T19:23:25.3037557Z �[36;1m  exit 1�[0m
2022-03-30T19:23:25.3037726Z �[36;1mfi�[0m
2022-03-30T19:23:25.3037948Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T19:23:25.3038382Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T19:23:25.3038694Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T19:23:25.3039027Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T19:23:25.3039358Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T19:23:25.3039672Z �[36;1m  exit 1�[0m
2022-03-30T19:23:25.3039838Z �[36;1mfi�[0m
2022-03-30T19:23:25.3040024Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T19:23:25.3050655Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T19:23:25.3050873Z env:
2022-03-30T19:23:25.3051020Z   IN_CI: 1
2022-03-30T19:23:25.3051183Z   IS_GHA: 1
2022-03-30T19:23:25.3051400Z   BASE_REVISION: 41a4e4ea94b602966ecf1eca2f807542d72b3a67
2022-03-30T19:23:25.3051808Z   DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7:a2c09c6009bb8a10cbb45a8c5f7c573593289be0

1 failure not recognized by patterns:

Job	Step	Action
^{pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge)}	^Test	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This is used inconsistently in all the generate_code program invocations. Nevertheless, nothing consumes this flag, so we can safely remove it. This was removed in #25353. Differential Revision: [D35053096](https://our.internmc.facebook.com/intern/diff/D35053096/) [ghstack-poisoned]

Pull Request resolved: #74563 This is used inconsistently in all the generate_code program invocations. Nevertheless, nothing consumes this flag, so we can safely remove it. This was removed in #25353. ghstack-source-id: 151910572 Differential Revision: [D35053096](https://our.internmc.facebook.com/intern/diff/D35053096/)

This is used inconsistently in all the generate_code program invocations. Nevertheless, nothing consumes this flag, so we can safely remove it. This was removed in #25353. Differential Revision: [D35053096](https://our.internmc.facebook.com/intern/diff/D35053096/) [ghstack-poisoned]

Summary: Pull Request resolved: #74563 This is used inconsistently in all the generate_code program invocations. Nevertheless, nothing consumes this flag, so we can safely remove it. This was removed in #25353. ghstack-source-id: 152249818 Test Plan: Should be a no-op, rely on CI. Reviewed By: malfet Differential Revision: D35053096 fbshipit-source-id: 3ad19e83ca14649b514dc163c3caff6cbd118e14

github-actions · 2022-03-31T18:36:10Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot added the cla signed label Mar 22, 2022

This was referenced Mar 22, 2022

move //tools/codegen:codegen into shared build structure #74386

Closed

use the //tools/codegen target in Bazel #74465

Closed

move codegen binary to the common build system #74470

Closed

use the shared //tools/codegen:gen in OSS Bazel #74471

Closed

dagitses mentioned this pull request Mar 24, 2022

read autograd templates and yaml files from resources #74672

Closed

Michael Andreas Dagitses added 9 commits March 24, 2022 05:21

dagitses mentioned this pull request Mar 25, 2022

move Bazel //:tools_autograd to the //tools/autograd package #74745

Closed

dagitses mentioned this pull request Mar 25, 2022

port Bazel //tools/autograd to shared build structure #74749

Closed

Michael Andreas Dagitses added 6 commits March 25, 2022 09:27

This was referenced Mar 28, 2022

remove dead code from generate_code program #74835

Closed

stop creating jit/generated/ directory #74836

Closed

remove unused //:tools_jit target and dependency from generate-code #74837

Closed

move setup_helpers programs to their own package #74838

Closed

Michael Andreas Dagitses added 2 commits March 28, 2022 09:58

dagitses mentioned this pull request Mar 28, 2022

move setup_helpers programs to shared build structure #74849

Closed

Michael Andreas Dagitses added 3 commits March 28, 2022 12:16

pytorchmergebot closed this in 60729d0 Mar 31, 2022

facebook-github-bot deleted the gh/dagitses/296/head branch April 4, 2022 14:17

WBobby mentioned this pull request Aug 17, 2022

Add ROCm5.2.3/AMDGPU support for PyTorch WBobby/pytorch#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove unused nn_path from generate_code #74563

remove unused nn_path from generate_code #74563

Uh oh!

dagitses commented Mar 22, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Mar 22, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

remove unused nn_path from generate_code #74563

remove unused nn_path from generate_code #74563

Uh oh!

Conversation

dagitses commented Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 3 new failures recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/3)

pull / linux-xenial-cuda11.3-py3.7-gcc7 / build (2/3)

pull / deploy-linux-xenial-cuda11.3-py3.7-gcc7 / build (3/3)

1 failure not recognized by patterns:

Uh oh!

github-actions bot commented Mar 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dagitses commented Mar 22, 2022 •

edited

Loading

facebook-github-bot commented Mar 22, 2022 •

edited

Loading