[SR] Native implementation for IntImplicit #74562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a native implementation for `aten::IntImplicit`, which is similar to `aten::Int` except for a few extra checks it must do Differential Revision: [D35052997](https://our.internmc.facebook.com/intern/diff/D35052997/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35052997/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2c5f291 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
mikeiovine
pushed a commit
that referenced
this pull request
Mar 22, 2022
Add a native implementation for `aten::IntImplicit`, which is similar to `aten::Int` except for a few extra checks it must do Differential Revision: [D35052997](https://our.internmc.facebook.com/intern/diff/D35052997/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35052997/)! ghstack-source-id: 151910134 Pull Request resolved: #74562
This was referenced Mar 22, 2022
added 3 commits
March 23, 2022 09:17
Add a native implementation for `aten::IntImplicit`, which is similar to `aten::Int` except for a few extra checks it must do Differential Revision: [D35052997](https://our.internmc.facebook.com/intern/diff/D35052997/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35052997/)! [ghstack-poisoned]
Add a native implementation for `aten::IntImplicit`, which is similar to `aten::Int` except for a few extra checks it must do Differential Revision: [D35052997](https://our.internmc.facebook.com/intern/diff/D35052997/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35052997/)! [ghstack-poisoned]
Add a native implementation for `aten::IntImplicit`, which is similar to `aten::Int` except for a few extra checks it must do Differential Revision: [D35052997](https://our.internmc.facebook.com/intern/diff/D35052997/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35052997/)! [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
Summary: Pull Request resolved: #74562 Add a native implementation for `aten::IntImplicit`, which is similar to `aten::Int` except for a few extra checks it must do ghstack-source-id: 152340039 Test Plan: New unit tests Reviewed By: hlu1 Differential Revision: D35052997 fbshipit-source-id: cb2f0faf7c62382e3f13750d8e1280c49c6b9e42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add a native implementation for
aten::IntImplicit, which is similar toaten::Intexcept for a few extra checks it must doDifferential Revision: D35052997
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!