Skip to content

Remove high priority as an owner for tests #74555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janeyx99 wants to merge 2 commits into from
Closed

Remove high priority as an owner for tests #74555

janeyx99 wants to merge 2 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Mar 22, 2022

Following triage review discussion, it would be best for these tests to not be triaged high priority by automation, but by the triagers in the oncall.

@janeyx99 janeyx99 requested a review from albanD March 22, 2022 17:15
janeyx99
janeyx99 commented Mar 22, 2022
View reviewed changes
test/test_python_dispatch.py
@@ -1,4 +1,4 @@
# Owner(s): ["high priority"]
# Owner(s): ["module: __torch_dispatch__"]
Copy link
Contributor Author

@janeyx99 janeyx99 Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed no one would be autotagged for this label (and the torch_function one) here #24422. Do we know the proper people owners for these?

Copy link
Collaborator

@albanD albanD Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually. Just that they get rendered by github UI

@janeyx99 janeyx99 mentioned this pull request Mar 22, 2022
Merged
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit b6cd2b9 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

albanD
albanD reviewed Mar 22, 2022
View reviewed changes
test/test_pytree.py
@@ -1,4 +1,4 @@
# Owner(s): ["high priority"]
# Owner(s): ["module: unknown"]
Copy link
Collaborator

@albanD albanD Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @zou3519 any idea of a good owner here?

test/test_python_dispatch.py
@@ -1,4 +1,4 @@
# Owner(s): ["high priority"]
# Owner(s): ["module: __torch_dispatch__"]
Copy link
Collaborator

@albanD albanD Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually. Just that they get rendered by github UI

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 23, 2022

@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 23, 2022

@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Mar 24, 2022
@janeyx99 @facebook-github-bot
Remove high priority as an owner for tests (#74555)
057519c 
Summary:
Following triage review discussion, it would be best for these tests to not be triaged high priority by automation, but by the triagers in the oncall.

Pull Request resolved: #74555

Reviewed By: albanD

Differential Revision: D35099202

Pulled By: janeyx99

fbshipit-source-id: 657a0317141de3a598476a6f601ec26cc26231b1
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2022

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

shahofblah pushed a commit that referenced this pull request Mar 25, 2022
@janeyx99 @shahofblah
Remove high priority as an owner for tests (#74555)
b0269d2 
Summary:
Following triage review discussion, it would be best for these tests to not be triaged high priority by automation, but by the triagers in the oncall.

Pull Request resolved: #74555

Reviewed By: albanD

Differential Revision: D35099202

Pulled By: janeyx99

fbshipit-source-id: 657a0317141de3a598476a6f601ec26cc26231b1
(cherry picked from commit 057519c)
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janeyx99 @facebook-github-bot @albanD