[quant][core][gpu] Wrapped CacheKey in Conv.cpp with anonymous namespace #74543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is done to prevent ODR issues with other cudnn ops and we want to make sure that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will also define CacheKey in their files. This PR should introduce no functional changes. Test plan: In pytorch main directory, execute ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` for accuracy testing and ``` python test/test_quantization.py TestQuantizedConv.test_benchmark ``` for benchmark testing. [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8640af7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
We have recently simplified the CIFlow labels and
|
…mous namespace" Summary: This is done to prevent ODR issues with other cudnn ops and we want to make sure that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will also define CacheKey in their files. This PR should introduce no functional changes. Test plan: In pytorch main directory, execute ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` for accuracy testing and ``` python test/test_quantization.py TestQuantizedConv.test_benchmark ``` for benchmark testing. [ghstack-poisoned]
…mous namespace" Summary: This is done to prevent ODR issues with other cudnn ops and we want to make sure that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will also define CacheKey in their files. This PR should introduce no functional changes. Test plan: In pytorch main directory, execute ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` for accuracy testing and ``` python test/test_quantization.py TestQuantizedConv.test_benchmark ``` for benchmark testing. [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…mous namespace" Summary: This is done to prevent ODR issues with other cudnn ops and we want to make sure that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will also define CacheKey in their files. This PR should introduce no functional changes. Test plan: In pytorch main directory, execute ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` for accuracy testing and ``` python test/test_quantization.py TestQuantizedConv.test_benchmark ``` for benchmark testing. Differential Revision: [D35066248](https://our.internmc.facebook.com/intern/diff/D35066248) [ghstack-poisoned]
jerryzh168
approved these changes
Mar 23, 2022
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
…ace (#74543) Summary: Pull Request resolved: #74543 This is done to prevent ODR issues with other cudnn ops and we want to make sure that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will also define CacheKey in their files. This PR should introduce no functional changes. Test Plan: In pytorch main directory, execute ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` for accuracy testing and ``` python test/test_quantization.py TestQuantizedConv.test_benchmark ``` for benchmark testing. Reviewed By: jerryzh168 Differential Revision: D35066248 Pulled By: dzdang fbshipit-source-id: 35ee55a4a140a96cba969ebf1b572c35b4822af8
Contributor
|
Hey @dzdang. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
…ace (#74543) Summary: Pull Request resolved: #74543 This is done to prevent ODR issues with other cudnn ops and we want to make sure that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will also define CacheKey in their files. This PR should introduce no functional changes. Test Plan: In pytorch main directory, execute ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` for accuracy testing and ``` python test/test_quantization.py TestQuantizedConv.test_benchmark ``` for benchmark testing. Reviewed By: jerryzh168 Differential Revision: D35066248 Pulled By: dzdang fbshipit-source-id: 35ee55a4a140a96cba969ebf1b572c35b4822af8 (cherry picked from commit f8637b2)
NesrineMHB
pushed a commit
to NesrineMHB/pytorch
that referenced
this pull request
Apr 8, 2022
Summary: This is done to prevent ODR issues with other cudnn ops and we want to make sure that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will also define CacheKey in their files. This PR should introduce no functional changes. Test plan: In pytorch main directory, execute ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` for accuracy testing and ``` python test/test_quantization.py TestQuantizedConv.test_benchmark ``` for benchmark testing. ghstack-source-id: 8c61979 Pull Request resolved: pytorch/pytorch#74543
NesrineMHB
pushed a commit
to NesrineMHB/pytorch
that referenced
this pull request
Apr 8, 2022
Summary: This is done to prevent ODR issues with other cudnn ops and we want to make sure that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will also define CacheKey in their files. This PR should introduce no functional changes. Test plan: In pytorch main directory, execute ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` for accuracy testing and ``` python test/test_quantization.py TestQuantizedConv.test_benchmark ``` for benchmark testing. ghstack-source-id: 8c61979 Pull Request resolved: pytorch/pytorch#74543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This is done to prevent ODR issues with other cudnn ops and we want to make sure
that the CacheKey in Conv.cpp is only used within this file. Other cudnn ops will
also define CacheKey in their files.
This PR should introduce no functional changes.
Test plan:
In pytorch main directory, execute
for accuracy testing and
for benchmark testing.
Differential Revision: D35066248