Skip to content

[PyTorch] Fix quantized linear_unpack ops not being registered issue #74526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
larryliu0820 wants to merge 2 commits into from
Closed

[PyTorch] Fix quantized linear_unpack ops not being registered issue #74526

larryliu0820 wants to merge 2 commits into from

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Mar 22, 2022

Summary: PR #73956 refactored qlinear_unpack.cpp and moved it out from the build system. Hence TORCH_LIBRARY_IMPL for qlinear_unpack ops are missing from the build. This PR adds it back.

Test Plan: CI

Differential Revision: D35039381

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit bc16ce9 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022

This pull request was exported from Phabricator. Differential Revision: D35039381

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022

This pull request was exported from Phabricator. Differential Revision: D35039381

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022

This pull request was exported from Phabricator. Differential Revision: D35039381

@larryliu0820 @facebook-github-bot
[PyTorch] Fix flatbuffer build error on Android
b808b61 
Summary:
This PR consists the following changes:
* Get rid of some unused variables, to workaround `-Werror, -Wunused-variables`.
* Use Android version of `align_alloc()`.

Test Plan: Tested Android build

Differential Revision: D35037344

fbshipit-source-id: a3876d1a675b6ec54a92e7386048c9db7b3507b0
@larryliu0820 @facebook-github-bot
[PyTorch] Fix quantized linear_unpack ops not being registered issue (p…
bc16ce9 
…ytorch#74526)

Summary:
Pull Request resolved: pytorch#74526

PR pytorch#73956 refactored `qlinear_unpack.cpp` and moved it out from the build system. Hence `TORCH_LIBRARY_IMPL` for `qlinear_unpack` ops are missing from the build. This PR adds it back.

Test Plan: CI

Differential Revision: D35039381

fbshipit-source-id: e633a7cc8cd85bfccfcb6152c144106d2403b679
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022

This pull request was exported from Phabricator. Differential Revision: D35039381

@larryliu0820 larryliu0820 requested a review from ezyang March 22, 2022 18:44
facebook-github-bot pushed a commit that referenced this pull request Mar 22, 2022
@larryliu0820 @facebook-github-bot
[PyTorch] Fix quantized linear_unpack ops not being registered issue (#…
9cf8c4c 
…74526)

Summary:
Pull Request resolved: #74526

PR #73956 refactored `qlinear_unpack.cpp` and moved it out from the build system. Hence `TORCH_LIBRARY_IMPL` for `qlinear_unpack` ops are missing from the build. This PR adds it back.

Test Plan: CI

Reviewed By: dzdang

Differential Revision: D35039381

fbshipit-source-id: 86f728f15ec8db25445215c34434a05b11c80e3f
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

Hey @larryliu0820.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

shahofblah pushed a commit that referenced this pull request Mar 25, 2022
@larryliu0820 @shahofblah
[PyTorch] Fix quantized linear_unpack ops not being registered issue (#…
280c846 
…74526)

Summary:
Pull Request resolved: #74526

PR #73956 refactored `qlinear_unpack.cpp` and moved it out from the build system. Hence `TORCH_LIBRARY_IMPL` for `qlinear_unpack` ops are missing from the build. This PR adds it back.

Test Plan: CI

Reviewed By: dzdang

Differential Revision: D35039381

fbshipit-source-id: 86f728f15ec8db25445215c34434a05b11c80e3f
(cherry picked from commit 9cf8c4c)
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

cla signed fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@larryliu0820 @facebook-github-bot