Skip to content

Fix issue with prim::Print() and torch::deploy #74513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
khabinov wants to merge 1 commit into from
Closed

Fix issue with prim::Print() and torch::deploy #74513

khabinov wants to merge 1 commit into from

Conversation

@khabinov
Copy link
Contributor

@khabinov khabinov commented Mar 22, 2022

Differential Revision: D35035089

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 63cab4c (more details on the Dr. CI page):

Commit 63cab4c was recently pushed. Waiting for builds...

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fb-exported labels Mar 22, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022

This pull request was exported from Phabricator. Differential Revision: D35035089

@yinghai yinghai requested a review from suo March 22, 2022 03:07
houseroad
houseroad approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2022

This pull request was exported from Phabricator. Differential Revision: D35035089

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 23, 2022

This pull request was exported from Phabricator. Differential Revision: D35035089

@khabinov @facebook-github-bot
Fix issue with prim::Print() and torch::deploy (pytorch#74513)
63cab4c 
Summary: Pull Request resolved: pytorch#74513

Reviewed By: d4l3k, houseroad

Differential Revision: D35035089

fbshipit-source-id: feb0b32c52ba6916d38e51c79c0b98a3da18de71
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2022

This pull request was exported from Phabricator. Differential Revision: D35035089

facebook-github-bot pushed a commit that referenced this pull request Mar 25, 2022
@khabinov @facebook-github-bot
Fix issue with prim::Print() and torch::deploy (#74513)
16caf86 
Summary: Pull Request resolved: #74513

Reviewed By: d4l3k, houseroad

Differential Revision: D35035089

fbshipit-source-id: d67b98600c74e2ed16b4d80f52148cd64b9e6ca0
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

Hey @khabinov.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

shahofblah pushed a commit that referenced this pull request Mar 25, 2022
@khabinov @shahofblah
Fix issue with prim::Print() and torch::deploy (#74513)
1f9cdb5 
Summary: Pull Request resolved: #74513

Reviewed By: d4l3k, houseroad

Differential Revision: D35035089

fbshipit-source-id: d67b98600c74e2ed16b4d80f52148cd64b9e6ca0
(cherry picked from commit 16caf86)
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

@suo suo Awaiting requested review from suo

Assignees

No one assigned

Labels

cla signed fb-exported oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khabinov @facebook-github-bot @houseroad