[quant][fx] Support conv1d and its fusion variants in QAT #74506

jerryzh168 · 2022-03-21T23:13:45Z

Stack from ghstack (oldest at bottom):

Summary:
This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization

Test Plan:
python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D35032995

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

facebook-github-bot · 2022-03-21T23:13:53Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/74506
↩️ [fb-only] Re-run with SSH instructions
Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit 3c423a0 (more details on the Dr. CI page):

3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pull / linux-bionic-py3.7-clang9 / test (default, 1, 2, linux.2xlarge) (1/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-23T07:08:22.1288201Z RuntimeError: test...edtuple_return_api failed! Received signal: SIGBUS

2022-03-23T07:08:21.8945546Z Generated XML report: test-reports/python-unittest/test_multiprocessing_spawn/TEST-ErrorTest-20220323070819.xml
2022-03-23T07:08:21.8954173Z Generated XML report: test-reports/python-unittest/test_multiprocessing_spawn/TEST-ForkTest-20220323070819.xml
2022-03-23T07:08:21.8963928Z Generated XML report: test-reports/python-unittest/test_multiprocessing_spawn/TEST-SpawnTest-20220323070819.xml
2022-03-23T07:08:22.0474356Z Running test_namedtuple_return_api ... [2022-03-23 07:08:22.047019]
2022-03-23T07:08:22.0474965Z Executing ['/opt/conda/bin/python', 'test_namedtuple_return_api.py', '-v', '--import-slow-tests', '--import-disabled-tests'] ... [2022-03-23 07:08:22.047108]
2022-03-23T07:08:22.1283064Z Traceback (most recent call last):
2022-03-23T07:08:22.1283356Z   File "test/run_test.py", line 1052, in <module>
2022-03-23T07:08:22.1285248Z     main()
2022-03-23T07:08:22.1285519Z   File "test/run_test.py", line 1030, in main
2022-03-23T07:08:22.1287684Z     raise RuntimeError(err_message)
2022-03-23T07:08:22.1288201Z RuntimeError: test_namedtuple_return_api failed! Received signal: SIGBUS
2022-03-23T07:08:22.3295508Z 
2022-03-23T07:08:22.3295773Z real	13m49.131s
2022-03-23T07:08:22.3296060Z user	48m52.809s
2022-03-23T07:08:22.3297303Z sys	7m2.130s
2022-03-23T07:08:22.3297584Z + cleanup
2022-03-23T07:08:22.3297812Z + retcode=1
2022-03-23T07:08:22.3298249Z + set +x
2022-03-23T07:08:22.3336871Z ##[error]Process completed with exit code 1.
2022-03-23T07:08:22.3398143Z ##[group]Run pytorch/pytorch/.github/actions/chown-workspace@master
2022-03-23T07:08:22.3398384Z env:

pull / win-vs2019-cuda11.3-py3 / build (2/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-23T07:11:03.7995915Z C:\actions-runner\...ult': no appropriate default constructor available

2022-03-23T07:11:03.7981373Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\exception(267): note: or       'bool std::operator ==(const std::exception_ptr &,const std::exception_ptr &) noexcept' [found using argument-dependent lookup]
2022-03-23T07:11:03.7983468Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\exception(271): note: or       'bool std::operator ==(std::nullptr_t,const std::exception_ptr &) noexcept' [found using argument-dependent lookup]
2022-03-23T07:11:03.7984864Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\exception(275): note: or       'bool std::operator ==(const std::exception_ptr &,std::nullptr_t) noexcept' [found using argument-dependent lookup]
2022-03-23T07:11:03.7986236Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\system_error(168): note: or       'bool std::operator ==(const std::error_code &,const std::error_code &) noexcept' [found using argument-dependent lookup]
2022-03-23T07:11:03.7987621Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\system_error(172): note: or       'bool std::operator ==(const std::error_code &,const std::error_condition &) noexcept' [found using argument-dependent lookup]
2022-03-23T07:11:03.7989018Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\system_error(176): note: or       'bool std::operator ==(const std::error_condition &,const std::error_code &) noexcept' [found using argument-dependent lookup]
2022-03-23T07:11:03.7990424Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\system_error(248): note: or       'bool std::operator ==(const std::error_condition &,const std::error_condition &) noexcept' [found using argument-dependent lookup]
2022-03-23T07:11:03.7991782Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\thread(204): note: or       'bool std::operator ==(std::thread::id,std::thread::id) noexcept' [found using argument-dependent lookup]
2022-03-23T07:11:03.7993576Z C:\actions-runner\_work\pytorch\pytorch\test\cpp\jit\test_lite_interpreter.cpp(1010): note: or       'built-in C++ operator==(std::streamoff, std::_Iosb<int>::_Seekdir)'
2022-03-23T07:11:03.7994718Z C:\actions-runner\_work\pytorch\pytorch\test\cpp\jit\test_lite_interpreter.cpp(1010): note: while trying to match the argument list '(std::fpos<_Mbstatet>, const std::_Iosb<int>::_Seekdir)'
2022-03-23T07:11:03.7995915Z C:\actions-runner\_work\pytorch\pytorch\test\cpp\jit\test_lite_interpreter.cpp(1010): error C2512: 'testing::AssertionResult': no appropriate default constructor available
2022-03-23T07:11:03.7997138Z C:\actions-runner\_work\pytorch\pytorch\test\cpp\jit\test_lite_interpreter.cpp(1010): note: No constructor could take the source type, or constructor overload resolution was ambiguous
2022-03-23T07:11:03.7998000Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64
2022-03-23T07:11:03.7998526Z Copyright (C) Microsoft Corporation.  All rights reserved.
2022-03-23T07:11:03.7998848Z 
2022-03-23T07:11:04.1611344Z [5920/6228] C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\bin\sccache-cl.exe   /TP -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DUSE_C10D_GLOO -DUSE_CUDA -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DUSE_GTEST -DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE=1 -D_OPENMP_NOFORCE_MANIFEST -IC:\actions-runner\_work\pytorch\pytorch\build\aten\src -IC:\actions-runner\_work\pytorch\pytorch\aten\src -IC:\actions-runner\_work\pytorch\pytorch\build -IC:\actions-runner\_work\pytorch\pytorch -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\benchmark\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\cudnn_frontend\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\onnx -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\onnx -IC:\actions-runner\_work\pytorch\pytorch\third_party\foxi -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\foxi -IC:\actions-runner\_work\pytorch\pytorch\build\caffe2\..\aten\src -IC:\actions-runner\_work\pytorch\pytorch\torch\csrc\api -IC:\actions-runner\_work\pytorch\pytorch\torch\csrc\api\include -IC:\actions-runner\_work\pytorch\pytorch\c10\.. -IC:\actions-runner\_work\pytorch\pytorch\c10\cuda\..\.. -IC:\actions-runner\_work\pytorch\pytorch\third_party\pthreadpool\include -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\gloo -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\gloo -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\googletest\googlemock\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\googletest\googletest\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\protobuf\src -IC:\actions-runner\_work\pytorch\pytorch\build\win_tmp\mkl\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\XNNPACK\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\eigen -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.3\include" -IC:\actions-runner\_work\pytorch\pytorch\third_party\ideep\mkl-dnn\third_party\oneDNN\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\ideep\include -I"C:\Program Files\NVIDIA Corporation\NvToolsExt\include" -IC:\actions-runner\_work\pytorch\pytorch\third_party\googletest\googletest\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\googletest\googletest /DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -IC:/actions-runner/_work/pytorch/pytorch/build/win_tmp/mkl/include -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOCUPTI -DUSE_FBGEMM -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -DEDGE_PROFILER_USE_KINETO -DHAVE_AVX512_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MD /O2 /Ob2 /DNDEBUG /w /bigobj -DNDEBUG -DCAFFE2_USE_GLOO -DTH_HAVE_THREAD /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -std:c++14 /showIncludes /Fotest_tensorexpr\CMakeFiles\test_tensorexpr.dir\test_ops.cpp.obj /Fdtest_tensorexpr\CMakeFiles\test_tensorexpr.dir\ /FS -c C:\actions-runner\_work\pytorch\pytorch\test\cpp\tensorexpr\test_ops.cpp
2022-03-23T07:11:04.1620291Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64
2022-03-23T07:11:04.1620990Z Copyright (C) Microsoft Corporation.  All rights reserved.
2022-03-23T07:11:04.1621308Z 
2022-03-23T07:11:04.3029013Z [5921/6228] C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\bin\sccache-cl.exe   /TP -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DUSE_C10D_GLOO -DUSE_CUDA -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DUSE_GTEST -DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE=1 -D_OPENMP_NOFORCE_MANIFEST -IC:\actions-runner\_work\pytorch\pytorch\build\aten\src -IC:\actions-runner\_work\pytorch\pytorch\aten\src -IC:\actions-runner\_work\pytorch\pytorch\build -IC:\actions-runner\_work\pytorch\pytorch -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\benchmark\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\cudnn_frontend\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\onnx -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\onnx -IC:\actions-runner\_work\pytorch\pytorch\third_party\foxi -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\foxi -IC:\actions-runner\_work\pytorch\pytorch\build\caffe2\..\aten\src -IC:\actions-runner\_work\pytorch\pytorch\torch\csrc\api -IC:\actions-runner\_work\pytorch\pytorch\torch\csrc\api\include -IC:\actions-runner\_work\pytorch\pytorch\c10\.. -IC:\actions-runner\_work\pytorch\pytorch\c10\cuda\..\.. -IC:\actions-runner\_work\pytorch\pytorch\third_party\pthreadpool\include -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\gloo -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\gloo -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\googletest\googlemock\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\googletest\googletest\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\protobuf\src -IC:\actions-runner\_work\pytorch\pytorch\build\win_tmp\mkl\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\XNNPACK\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\eigen -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.3\include" -IC:\actions-runner\_work\pytorch\pytorch\third_party\ideep\mkl-dnn\third_party\oneDNN\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\ideep\include -I"C:\Program Files\NVIDIA Corporation\NvToolsExt\include" -IC:\actions-runner\_work\pytorch\pytorch\third_party\googletest\googletest\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\googletest\googletest /DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -IC:/actions-runner/_work/pytorch/pytorch/build/win_tmp/mkl/include -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOCUPTI -DUSE_FBGEMM -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -DEDGE_PROFILER_USE_KINETO -DHAVE_AVX512_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MD /O2 /Ob2 /DNDEBUG /w /bigobj -DNDEBUG -DCAFFE2_USE_GLOO -DTH_HAVE_THREAD /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -std:c++14 /showIncludes /Fotest_tensorexpr\CMakeFiles\test_tensorexpr.dir\padded_buffer.cpp.obj /Fdtest_tensorexpr\CMakeFiles\test_tensorexpr.dir\ /FS -c C:\actions-runner\_work\pytorch\pytorch\test\cpp\tensorexpr\padded_buffer.cpp
2022-03-23T07:11:04.3038103Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64

pull / win-vs2019-cpu-py3 / build (3/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-23T06:56:28.7662968Z C:\actions-runner\...ult': no appropriate default constructor available

2022-03-23T06:56:28.7647519Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\exception(267): note: or       'bool std::operator ==(const std::exception_ptr &,const std::exception_ptr &) noexcept' [found using argument-dependent lookup]
2022-03-23T06:56:28.7649045Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\exception(271): note: or       'bool std::operator ==(std::nullptr_t,const std::exception_ptr &) noexcept' [found using argument-dependent lookup]
2022-03-23T06:56:28.7650541Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\exception(275): note: or       'bool std::operator ==(const std::exception_ptr &,std::nullptr_t) noexcept' [found using argument-dependent lookup]
2022-03-23T06:56:28.7652787Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\system_error(168): note: or       'bool std::operator ==(const std::error_code &,const std::error_code &) noexcept' [found using argument-dependent lookup]
2022-03-23T06:56:28.7654376Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\system_error(172): note: or       'bool std::operator ==(const std::error_code &,const std::error_condition &) noexcept' [found using argument-dependent lookup]
2022-03-23T06:56:28.7656194Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\system_error(176): note: or       'bool std::operator ==(const std::error_condition &,const std::error_code &) noexcept' [found using argument-dependent lookup]
2022-03-23T06:56:28.7657730Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\system_error(248): note: or       'bool std::operator ==(const std::error_condition &,const std::error_condition &) noexcept' [found using argument-dependent lookup]
2022-03-23T06:56:28.7659194Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\thread(204): note: or       'bool std::operator ==(std::thread::id,std::thread::id) noexcept' [found using argument-dependent lookup]
2022-03-23T06:56:28.7660474Z C:\actions-runner\_work\pytorch\pytorch\test\cpp\jit\test_lite_interpreter.cpp(1010): note: or       'built-in C++ operator==(std::streamoff, std::_Iosb<int>::_Seekdir)'
2022-03-23T06:56:28.7661675Z C:\actions-runner\_work\pytorch\pytorch\test\cpp\jit\test_lite_interpreter.cpp(1010): note: while trying to match the argument list '(std::fpos<_Mbstatet>, const std::_Iosb<int>::_Seekdir)'
2022-03-23T06:56:28.7662968Z C:\actions-runner\_work\pytorch\pytorch\test\cpp\jit\test_lite_interpreter.cpp(1010): error C2512: 'testing::AssertionResult': no appropriate default constructor available
2022-03-23T06:56:28.7664294Z C:\actions-runner\_work\pytorch\pytorch\test\cpp\jit\test_lite_interpreter.cpp(1010): note: No constructor could take the source type, or constructor overload resolution was ambiguous
2022-03-23T06:56:28.7665249Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64
2022-03-23T06:56:28.7666070Z Copyright (C) Microsoft Corporation.  All rights reserved.
2022-03-23T06:56:28.7666413Z 
2022-03-23T06:56:28.7906367Z [5618/5809] C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\bin\sccache-cl.exe   /TP -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DUSE_C10D_GLOO -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DUSE_GTEST -DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE=1 -D_OPENMP_NOFORCE_MANIFEST -IC:\actions-runner\_work\pytorch\pytorch\build\aten\src -IC:\actions-runner\_work\pytorch\pytorch\aten\src -IC:\actions-runner\_work\pytorch\pytorch\build -IC:\actions-runner\_work\pytorch\pytorch -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\benchmark\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\onnx -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\onnx -IC:\actions-runner\_work\pytorch\pytorch\third_party\foxi -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\foxi -IC:\actions-runner\_work\pytorch\pytorch\build\caffe2\..\aten\src -IC:\actions-runner\_work\pytorch\pytorch\torch\csrc\api -IC:\actions-runner\_work\pytorch\pytorch\torch\csrc\api\include -IC:\actions-runner\_work\pytorch\pytorch\c10\.. -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\gloo -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\gloo -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\googletest\googlemock\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\googletest\googletest\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\protobuf\src -IC:\actions-runner\_work\pytorch\pytorch\build\win_tmp\mkl\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\XNNPACK\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\eigen -IC:\actions-runner\_work\pytorch\pytorch\third_party\ideep\mkl-dnn\third_party\oneDNN\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\ideep\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\googletest\googletest\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\googletest\googletest /DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -IC:/actions-runner/_work/pytorch/pytorch/build/win_tmp/mkl/include -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOCUPTI -DUSE_FBGEMM -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -DEDGE_PROFILER_USE_KINETO -DHAVE_AVX512_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MD /O2 /Ob2 /DNDEBUG /w /bigobj -DNDEBUG -DCAFFE2_USE_GLOO -DTH_HAVE_THREAD /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -std:c++14 /showIncludes /Fotest_lazy\CMakeFiles\test_lazy.dir\test_backend_device.cpp.obj /Fdtest_lazy\CMakeFiles\test_lazy.dir\ /FS -c C:\actions-runner\_work\pytorch\pytorch\test\cpp\lazy\test_backend_device.cpp
2022-03-23T06:56:28.7914799Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64
2022-03-23T06:56:28.7915388Z Copyright (C) Microsoft Corporation.  All rights reserved.
2022-03-23T06:56:28.7915739Z 
2022-03-23T06:56:29.3205695Z [5619/5809] C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\bin\sccache-cl.exe   /TP -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DUSE_C10D_GLOO -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DUSE_GTEST -DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE=1 -D_OPENMP_NOFORCE_MANIFEST -IC:\actions-runner\_work\pytorch\pytorch\build\aten\src -IC:\actions-runner\_work\pytorch\pytorch\aten\src -IC:\actions-runner\_work\pytorch\pytorch\build -IC:\actions-runner\_work\pytorch\pytorch -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\benchmark\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\onnx -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\onnx -IC:\actions-runner\_work\pytorch\pytorch\third_party\foxi -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\foxi -IC:\actions-runner\_work\pytorch\pytorch\build\caffe2\..\aten\src -IC:\actions-runner\_work\pytorch\pytorch\torch\csrc\api -IC:\actions-runner\_work\pytorch\pytorch\torch\csrc\api\include -IC:\actions-runner\_work\pytorch\pytorch\c10\.. -IC:\actions-runner\_work\pytorch\pytorch\build\third_party\gloo -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\gloo -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\googletest\googlemock\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\googletest\googletest\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\protobuf\src -IC:\actions-runner\_work\pytorch\pytorch\build\win_tmp\mkl\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\XNNPACK\include -IC:\actions-runner\_work\pytorch\pytorch\cmake\..\third_party\eigen -IC:\actions-runner\_work\pytorch\pytorch\third_party\ideep\mkl-dnn\third_party\oneDNN\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\ideep\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\googletest\googletest\include -IC:\actions-runner\_work\pytorch\pytorch\third_party\googletest\googletest /DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -IC:/actions-runner/_work/pytorch/pytorch/build/win_tmp/mkl/include -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOCUPTI -DUSE_FBGEMM -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -DEDGE_PROFILER_USE_KINETO -DHAVE_AVX512_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MD /O2 /Ob2 /DNDEBUG /w /bigobj -DNDEBUG -DCAFFE2_USE_GLOO -DTH_HAVE_THREAD /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -std:c++14 /showIncludes /Fotest_lazy\CMakeFiles\test_lazy.dir\test_tensor_impl.cpp.obj /Fdtest_lazy\CMakeFiles\test_lazy.dir\ /FS -c C:\actions-runner\_work\pytorch\pytorch\test\cpp\lazy\test_tensor_impl.cpp
2022-03-23T06:56:29.3214744Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 · 2022-03-21T23:52:44Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35032995](https://our.internmc.facebook.com/intern/diff/D35032995) [ghstack-poisoned]

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization TODO: add tests for conv - relu, maybe after we decide whether we want to refactor our tests to be smaller Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: fffbb4c Pull Request resolved: #74506

jerryzh168 · 2022-03-22T00:00:57Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

vkuzo · 2022-03-22T12:34:53Z

what's the plan for Eager mode workflow support? Can we also add it either in this PR or in a follow-up PR?

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35032995](https://our.internmc.facebook.com/intern/diff/D35032995) [ghstack-poisoned]

jerryzh168 · 2022-03-22T21:54:51Z

what's the plan for Eager mode workflow support? Can we also add it either in this PR or in a follow-up PR?

we should support it, but not sure if it is P0 or not, the tests in eager mode could be refactored to be more general so that adding test is easier

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35032995](https://our.internmc.facebook.com/intern/diff/D35032995) [ghstack-poisoned]

jerryzh168 · 2022-03-22T23:04:02Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35032995](https://our.internmc.facebook.com/intern/diff/D35032995) [ghstack-poisoned]

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization TODO: add tests for conv - relu, maybe after we decide whether we want to refactor our tests to be smaller Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 58e014e Pull Request resolved: #74506

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35032995](https://our.internmc.facebook.com/intern/diff/D35032995) [ghstack-poisoned]

Summary: This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization TODO: add tests for conv - relu, maybe after we decide whether we want to refactor our tests to be smaller Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2485a7c Pull Request resolved: #74506

jerryzh168 · 2022-03-23T06:46:10Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

vkuzo · 2022-03-23T18:39:01Z

we should support it, but not sure if it is P0 or not, the tests in eager mode could be refactored to be more general so that adding test is easier

I think that it should ideally be added at the same priority, both Eager mode and FX graph mode are first class citizens.

Summary: Pull Request resolved: #74506 This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Imported from OSS Reviewed By: vkuzo Differential Revision: D35032995 fbshipit-source-id: 645da33f0d893aa44f35ee1384fd1539a9c788e7

Summary: Pull Request resolved: #74506 This PR supports qat Conv1d, ConvBn1d, ConvBnReLU1d, ConvReLU1d in qat in FX Graph Mode Quantization Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Imported from OSS Reviewed By: vkuzo Differential Revision: D35032995 fbshipit-source-id: 645da33f0d893aa44f35ee1384fd1539a9c788e7 (cherry picked from commit 6b583ba)

jerryzh168 requested review from albanD and jbschlosser as code owners March 21, 2022 23:13

jerryzh168 mentioned this pull request Mar 21, 2022

[quant][core] Refactor qat conv implementation to use the same _ConvNd as base class #74505

Closed

facebook-github-bot added the cla signed label Mar 21, 2022

facebook-github-bot added the module: fx label Mar 21, 2022

albanD removed their request for review March 21, 2022 23:53

jerryzh168 requested review from andrewor14 and vkuzo March 21, 2022 23:53

vkuzo approved these changes Mar 22, 2022

View reviewed changes

jerryzh168 added release notes: quantization release notes category topic: improvements topic category labels Mar 23, 2022

pytorchmergebot closed this in e9776fe Mar 23, 2022

facebook-github-bot deleted the gh/jerryzh168/752/head branch March 27, 2022 14:17

WBobby mentioned this pull request Aug 17, 2022

Add ROCm5.2.3/AMDGPU support for PyTorch WBobby/pytorch#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[quant][fx] Support conv1d and its fusion variants in QAT #74506

[quant][fx] Support conv1d and its fusion variants in QAT #74506

Uh oh!

jerryzh168 commented Mar 21, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Mar 21, 2022 •

edited

Loading

Uh oh!

jerryzh168 commented Mar 21, 2022

Uh oh!

jerryzh168 commented Mar 22, 2022

Uh oh!

vkuzo commented Mar 22, 2022

Uh oh!

jerryzh168 commented Mar 22, 2022

Uh oh!

jerryzh168 commented Mar 22, 2022

Uh oh!

jerryzh168 commented Mar 23, 2022

Uh oh!

vkuzo commented Mar 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[quant][fx] Support conv1d and its fusion variants in QAT #74506

[quant][fx] Support conv1d and its fusion variants in QAT #74506

Uh oh!

Conversation

jerryzh168 commented Mar 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 3 new failures recognized by patterns

pull / linux-bionic-py3.7-clang9 / test (default, 1, 2, linux.2xlarge) (1/3)

pull / win-vs2019-cuda11.3-py3 / build (2/3)

pull / win-vs2019-cpu-py3 / build (3/3)

Uh oh!

jerryzh168 commented Mar 21, 2022

Uh oh!

jerryzh168 commented Mar 22, 2022

Uh oh!

vkuzo commented Mar 22, 2022

Uh oh!

jerryzh168 commented Mar 22, 2022

Uh oh!

jerryzh168 commented Mar 22, 2022

Uh oh!

jerryzh168 commented Mar 23, 2022

Uh oh!

vkuzo commented Mar 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jerryzh168 commented Mar 21, 2022 •

edited

Loading

facebook-github-bot commented Mar 21, 2022 •

edited

Loading