[quant][core] Refactor qat conv implementation to use the same _ConvNd as base class #74505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d as base class Summary: att, this is to make supporting conv1d easier in future PR Test Plan: regression tests python test/test_quantization.py TestQuantizeFx Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7386bdf (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
…same _ConvNd as base class" Summary: att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…same _ConvNd as base class" Summary: att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35031523](https://our.internmc.facebook.com/intern/diff/D35031523) [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
vkuzo
approved these changes
Mar 22, 2022
…same _ConvNd as base class" Summary: att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35031523](https://our.internmc.facebook.com/intern/diff/D35031523) [ghstack-poisoned]
…same _ConvNd as base class" Summary: att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35031523](https://our.internmc.facebook.com/intern/diff/D35031523) [ghstack-poisoned]
…same _ConvNd as base class" Summary: att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35031523](https://our.internmc.facebook.com/intern/diff/D35031523) [ghstack-poisoned]
…same _ConvNd as base class" Summary: att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35031523](https://our.internmc.facebook.com/intern/diff/D35031523) [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…same _ConvNd as base class" Summary: att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35031523](https://our.internmc.facebook.com/intern/diff/D35031523) [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
…d as base class (#74505) Summary: Pull Request resolved: #74505 att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Imported from OSS Reviewed By: vkuzo Differential Revision: D35031523 fbshipit-source-id: b630eeef49cd25e939a9891535d05c62cbad0114
Contributor
|
Hey @jerryzh168. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
…d as base class (#74505) Summary: Pull Request resolved: #74505 att, this is to make supporting conv1d easier in future PR Test Plan: python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu Imported from OSS Reviewed By: vkuzo Differential Revision: D35031523 fbshipit-source-id: b630eeef49cd25e939a9891535d05c62cbad0114 (cherry picked from commit 563c789)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
att, this is to make supporting conv1d easier in future PR
Test Plan:
python test/test_quantization.py TestQuantizeFx.test_conv_bn_relu
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35031523