-
Notifications
You must be signed in to change notification settings - Fork 26.3k
move codegen binary to the common build system #74470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 78030ed (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Internally, use it as well. Differential Revision: [D35011144](https://our.internmc.facebook.com/intern/diff/D35011144/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35011144/)! [ghstack-poisoned]
Summary: Pull Request resolved: #74470 Internally, use it as well. ghstack-source-id: 152438657 Test Plan: Rely on CI to validate. Reviewed By: malfet Differential Revision: D35011144 fbshipit-source-id: fb7247470df579ae23fcbc74bd2f8d6cc55cf657
|
Hey @dagitses. |
Stack from ghstack (oldest at bottom):
Internally, use it as well.
Differential Revision: D35011144
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!