Print reason for test skipped in CI #74451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 9e55e75 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
tenpercent
changed the title
tenpercent
force-pushed
the
test-dummy-modification
branch
from
f5195c5 to
a78684c
Compare
janeyx99
reviewed
Mar 21, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| # patching library code to add verbosity to test outputs | |
| # patching library code to add verbosity to test outputs: the default captures verbose_str as skip, | |
| # but we want it to be skip reason. |
tenpercent
changed the title
tenpercent
force-pushed
the
test-dummy-modification
branch
from
6bf3cf2 to
9e55e75
Compare
janeyx99
approved these changes
Mar 22, 2022
Contributor
janeyx99
left a comment
janeyx99
left a comment
There was a problem hiding this comment.
Awesome! The test reports don't seem to have changed, so this is good to land :)
Contributor
|
@tenpercent has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
Summary: Issue: #69014 (skip reason is not printed for tests running in CI) Cause: locally tests are fired with testrunner that is built into unittest. When IN_CI env variable is true - tests are fired with xml test runner from unittest-xml-reporting. They have different summary printing properties Solution: patching printing logic in unittest-xml-reporting when a test is skipped Pull Request resolved: #74451 Test Plan: examine CI run Reviewed By: janeyx99 Differential Revision: D35050675 Pulled By: tenpercent fbshipit-source-id: e3421687d68932079ba156153abeefee368b2fb3
Contributor
|
Hey @tenpercent. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Issue: #69014 (skip reason is not printed for tests running in CI) Cause: locally tests are fired with testrunner that is built into unittest. When IN_CI env variable is true - tests are fired with xml test runner from unittest-xml-reporting. They have different summary printing properties Solution: patching printing logic in unittest-xml-reporting when a test is skipped Pull Request resolved: #74451 Test Plan: examine CI run Reviewed By: janeyx99 Differential Revision: D35050675 Pulled By: tenpercent fbshipit-source-id: e3421687d68932079ba156153abeefee368b2fb3 (cherry picked from commit e2356d8)
This was referenced Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #69014 (skip reason is not printed for tests running in CI)
Cause: locally tests are fired with testrunner that is built into unittest. When IN_CI env variable is true - tests are fired with xml test runner from unittest-xml-reporting. They have different summary printing properties
Solution: patching printing logic in unittest-xml-reporting when a test is skipped
Test plan: examine CI run