Torchhub: automatically disambiguate ref if it's both a branch and a tag #74418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 891ff0d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
added
triaged
NicolasHug
commented
Mar 18, 2022
Member
Author
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Closes #74368
This PR does 2 things:
- Update the URL where we download the archive, according to the latest github API docs https://docs.github.com/en/rest/reference/repos#download-a-repository-archive-zip
- When a user hits a 300 because the requested ref exists both as a branch and a tag, torchhub now re-tries to download the repo, assuming it's a branch (just like
git).
I'm not adding test right now because the tests require access to Ailing's private repo. We should find a better way to do this. But meanwhile, the following testplan will be enough:
from pytest import skip
import torch
try:
torch.hub.load("pytorch/vision:v0.5.0", "resnet18", force_reload=True)
except ImportError as e:
# We're loading a super old torchvision version so the import error is expected.
# It's completely unrelated to the changes made to torchhub.
assert "cannot import name 'PY3' from 'torch._six'" in str(e)
pass
# We can also load tags and branches explicitly without issue:
torch.hub.load("pytorch/vision:refs/tags/v0.5.0", "resnet18", force_reload=True, skip_validation=True)
torch.hub.load("pytorch/vision:refs/heads/v0.5.0", "resnet18", force_reload=True, skip_validation=True)| def _parse_repo_info(github): | ||
| if ':' in github: | ||
| repo_info, branch = github.split(':') | ||
| repo_info, ref = github.split(':') |
Member
Author
There was a problem hiding this comment.
I renamed (private) uses of the term "branch" into "ref", as this is more accurate. This is somewhat orthogonal to the relevant changes made in this PR, so I can revert if it makes the review difficult.
vmoens
approved these changes
Mar 21, 2022
Contributor
vmoens
left a comment
vmoens
left a comment
There was a problem hiding this comment.
LGTM thanks for fixing this!
Member
Author
|
@NicolasHug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
Hey @NicolasHug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D35008926