Remove default parameter of ShufflerIterDataPipe #74370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5aa0cf1 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
commented
Mar 17, 2022
| return val | ||
|
|
||
| def set_shuffle_settings(self, shuffle=True): | ||
| def set_shuffle(self, shuffle=True): |
Member
Author
There was a problem hiding this comment.
Another suggestion I have for this would be enable_shuffle() or enable_shuffling(). But no strong opinion.
Collaborator
There was a problem hiding this comment.
I also thought about that, but I always feel strange doing something like enable_shuffle(False).
Contributor
There was a problem hiding this comment.
If we want to have such syntax sugar, I prefer to have enable_shuffle() and disable_shuffle()
pmeier
approved these changes
Mar 17, 2022
| return val | ||
|
|
||
| def set_shuffle_settings(self, shuffle=True): | ||
| def set_shuffle(self, shuffle=True): |
Collaborator
There was a problem hiding this comment.
I also thought about that, but I always feel strange doing something like enable_shuffle(False).
torch/utils/data/graph_settings.py
Outdated
| for pipe in all_pipes: | ||
| if hasattr(pipe, 'set_shuffle_settings'): | ||
| pipe.set_shuffle_settings(shuffle) | ||
| if hasattr(pipe, 'set_shuffle'): |
Collaborator
There was a problem hiding this comment.
Shouldn't we do isinstance(pipe, Shuffler) here? Checking for a public attribute seems sketchy.
| self.datapipe = datapipe.unbatch(unbatch_level=unbatch_level) | ||
| self.buffer_size = buffer_size | ||
| self._shuffle_enabled = default | ||
| self._shuffle_enabled = True |
Collaborator
There was a problem hiding this comment.
Maybe just
Suggested change
| self._shuffle_enabled = True | |
| self._enabled = True |
?
Closes meta-pytorch/data#298. This PR: - removes the `default` parameter of `ShufflerIterDataPipe` - renames `set_shuffle_setting()` into `set_shuffle()` - let `set_shuffle()` return `self`. [ghstack-poisoned]
Member
Author
|
Thanks for the review Philip! Happy to apply the recommended changes, I'll just wait for Erjia's or Kevin's input.
I just added a minimal one now |
Closes meta-pytorch/data#298. This PR: - removes the `default` parameter of `ShufflerIterDataPipe` - renames `set_shuffle_setting()` into `set_shuffle()` - let `set_shuffle()` return `self`. [ghstack-poisoned]
NicolasHug
commented
Mar 17, 2022
Contributor
Closes meta-pytorch/data#298. This PR: - removes the `default` parameter of `ShufflerIterDataPipe` - renames `set_shuffle_setting()` into `set_shuffle()` - let `set_shuffle()` return `self`. [ghstack-poisoned]
ejguan
approved these changes
Mar 21, 2022
Contributor
ejguan
left a comment
ejguan
left a comment
There was a problem hiding this comment.
Thanks for fixing it. LGTM with the similar comment with Philip
| return val | ||
|
|
||
| def set_shuffle_settings(self, shuffle=True): | ||
| def set_shuffle(self, shuffle=True): |
Contributor
There was a problem hiding this comment.
If we want to have such syntax sugar, I prefer to have enable_shuffle() and disable_shuffle()
torch/utils/data/graph_settings.py
Outdated
| for pipe in all_pipes: | ||
| if hasattr(pipe, 'set_shuffle_settings'): | ||
| pipe.set_shuffle_settings(shuffle) | ||
| if hasattr(pipe, 'set_shuffle'): |
Closes meta-pytorch/data#298. This PR: - removes the `default` parameter of `ShufflerIterDataPipe` - renames `set_shuffle_setting()` into `set_shuffle()` - let `set_shuffle()` return `self`. [ghstack-poisoned]
Member
Author
|
@NicolasHug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
VitalyFedyunin
approved these changes
Mar 23, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
Summary: Pull Request resolved: #74370 Closes meta-pytorch/data#298. This PR: - removes the `default` parameter of `ShufflerIterDataPipe` - renames `set_shuffle_setting()` into `set_shuffle()` - let `set_shuffle()` return `self`. Test Plan: Imported from OSS Reviewed By: george-qi Differential Revision: D35073666 Pulled By: NicolasHug fbshipit-source-id: 9847b037e70f44f36eaf4471f2c12fa8ec2ed73c
Contributor
|
Hey @NicolasHug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes meta-pytorch/data#298. This PR:
defaultparameter ofShufflerIterDataPipeset_shuffle_setting()intoset_shuffle()set_shuffle()returnself.Stack from ghstack (oldest at bottom):
Differential Revision: D35073666