utils: Only check for xnnpack if torch installed #74342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where collect_env.py was not able to be run without having torch installed Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 25f2a49 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
janeyx99
approved these changes
Mar 16, 2022
Member
Author
|
@pytorchbot merge this |
Collaborator
|
Merge failed due to PR 74342 does not match merge rules |
Member
Author
sadness |
Contributor
|
@seemethere has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
malfet
approved these changes
Mar 17, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
Summary: Fixes a bug where collect_env.py was not able to be run without having torch installed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #74342 Reviewed By: malfet, janeyx99 Differential Revision: D34943464 Pulled By: seemethere fbshipit-source-id: dbaa0004b88cb643a9c6426c9ea7c5be3d3c9ef5
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 17, 2022
This wasn't previously tested but this script is an essential tool that we use to help users present debug information on issues so we treat it with a similar level of care Depends on #74342 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #74347 Approved by: https://github.com/janeyx99, https://github.com/malfet
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
Summary: This wasn't previously tested but this script is an essential tool that we use to help users present debug information on issues so we treat it with a similar level of care Depends on #74342 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #74347 Approved by: https://github.com/janeyx99, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/abc868dd6446434dc519d3c5d9d210b2d406781c Reviewed By: malfet, osalpekar Differential Revision: D34968519 Pulled By: seemethere fbshipit-source-id: 59246cd1fbe4fe2ecdaeb5c1e4f988da57bee045
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
This wasn't previously tested but this script is an essential tool that we use to help users present debug information on issues so we treat it with a similar level of care Depends on #74342 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #74347 Approved by: https://github.com/janeyx99, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where collect_env.py was not able to be run without having
torch installed
Signed-off-by: Eli Uriegas eliuriegas@fb.com