[WIP][fx2trt] Replacing fp16 and int8 mode with enum type (#24) #74338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8137f35 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34929680 |
) Summary: Pull Request resolved: pytorch#74338 X-link: meta-pytorch/fx2trt#24 X-link: pytorch/benchmark#805 Test Plan: CI Reviewed By: jasonjk-park Differential Revision: D34929680 fbshipit-source-id: d96542d53922687a567407503a32cf38c0d3f9ad
brad-mengchi
pushed a commit
to brad-mengchi/benchmark
that referenced
this pull request
Mar 16, 2022
Summary: X-link: pytorch/pytorch#74338 X-link: meta-pytorch/fx2trt#24 Pull Request resolved: pytorch#805 Reviewed By: jasonjk-park Differential Revision: D34929680 fbshipit-source-id: c7657a002aeb5ffc51ce7765a4c2778cb357ff32
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34929680 |
brad-mengchi
force-pushed
the
export-D34929680
branch
from
8945f1c to
8137f35
Compare
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Mar 17, 2022
Summary: X-link: pytorch/pytorch#74338 X-link: meta-pytorch/fx2trt#24 Pull Request resolved: #805 Reviewed By: jasonjk-park Differential Revision: D34929680 fbshipit-source-id: 8d693ffdfc28d12f5b88aba170da87b192c5e5a2
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
Summary: Pull Request resolved: #74338 X-link: meta-pytorch/fx2trt#24 X-link: pytorch/benchmark#805 Test Plan: CI Reviewed By: jasonjk-park Differential Revision: D34929680 fbshipit-source-id: 8d693ffdfc28d12f5b88aba170da87b192c5e5a2
Contributor
|
Hey @brad-mengchi. |
Member
|
@yinghai it looks like there is still some fx2trt code in PT. These sort of split diffs will be hard to land in GHF world—anyone on the team looking at removing it? |
frank-wei
pushed a commit
to pytorch/TensorRT
that referenced
this pull request
Jun 4, 2022
Summary: X-link: pytorch/pytorch#74338 Pull Request resolved: https://github.com/pytorch/fx2trt/pull/24 X-link: pytorch/benchmark#805 Reviewed By: jasonjk-park Differential Revision: D34929680 fbshipit-source-id: 8d693ffdfc28d12f5b88aba170da87b192c5e5a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/pytorch/fx2trt/pull/24
X-link: pytorch/benchmark#805
Test Plan: CI
Differential Revision: D34929680