[pkg] Improve mocked module detection by combining mocked object errors with the rest of the errors in PackageExporter #74315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs with the rest of the errors in PackageExporter [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit f7b4555 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Contributor
Author
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
CI Flow Status⚛️ CI FlowRuleset - Version:
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
…rs with the rest of the errors in PackageExporter (#74315) Summary: Pull Request resolved: #74315 Now instead of spitting out a NotImplemented Error when the Package Exporter finds an object for a mocked module, it combines these errors with the rest of the Packaging Errors of PackageExporter to get something like ``` torch.package.package_exporter.PackagingError: * Module was mocked out, but is still being used in the package.Please intern or extern the mocked modules if objects are supposed to be inthe package. package_a Context: Object(s) '['PackageASubpackageObject']' from module package_a was mocked out during packaging but is being used in resource - obj.pkl in package obj. package_a.subpackage Context: Object(s) '['PackageASubpackageObject']' from module package_a.subpackage was mocked out during packaging but is being used in resource - obj.pkl in package obj. ``` This makes it significantly easier to fix mocked object errors as they all should appear at once. Test Plan: Imported from OSS Reviewed By: aivanou Differential Revision: D34932200 Pulled By: PaliC fbshipit-source-id: 7f12bd88dbfbad974fd04b5dcaba3203b5c68a04
Contributor
|
Hey @PaliC. |
Member
|
Sadly, this PR broke lint. I am reverting |
Member
|
GHA had an outage this morning, if you look CI didn't run on this PR at all |
Contributor
|
This pull request has been reverted by 577bf04. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
…object errors with the rest of the errors in PackageExporter"
Now instead of spitting out a NotImplemented Error when the Package Exporter finds an object for a mocked module, it combines these errors with the rest of the Packaging Errors of PackageExporter to get something like
```
torch.package.package_exporter.PackagingError:
* Module was mocked out, but is still being used in the package.Please intern or extern the mocked modules if objects are supposed to be inthe package.
package_a
Context: Object(s) '['PackageASubpackageObject']' from module package_a was mocked out during packaging but is being used in resource - obj.pkl in package obj.
package_a.subpackage
Context: Object(s) '['PackageASubpackageObject']' from module package_a.subpackage was mocked out during packaging but is being used in resource - obj.pkl in package obj.
```
This makes it significantly easier to fix mocked object errors as they all should appear at once.
[ghstack-poisoned]
Contributor
Author
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
…rs with the rest of the errors in PackageExporter (#74315) Summary: Pull Request resolved: #74315 Now instead of spitting out a NotImplemented Error when the Package Exporter finds an object for a mocked module, it combines these errors with the rest of the Packaging Errors of PackageExporter to get something like ``` torch.package.package_exporter.PackagingError: * Module was mocked out, but is still being used in the package.Please intern or extern the mocked modules if objects are supposed to be inthe package. package_a Context: Object(s) '['PackageASubpackageObject']' from module package_a was mocked out during packaging but is being used in resource - obj.pkl in package obj. package_a.subpackage Context: Object(s) '['PackageASubpackageObject']' from module package_a.subpackage was mocked out during packaging but is being used in resource - obj.pkl in package obj. ``` This makes it significantly easier to fix mocked object errors as they all should appear at once. Test Plan: Imported from OSS Reviewed By: d4l3k Differential Revision: D34951973 Pulled By: PaliC fbshipit-source-id: 01ee4ba3767967ef9a9bcd69ad86362ebc100b2d
Contributor
|
Hey @PaliC. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
…rs with the rest of the errors in PackageExporter (#74315) Summary: Pull Request resolved: #74315 Now instead of spitting out a NotImplemented Error when the Package Exporter finds an object for a mocked module, it combines these errors with the rest of the Packaging Errors of PackageExporter to get something like ``` torch.package.package_exporter.PackagingError: * Module was mocked out, but is still being used in the package.Please intern or extern the mocked modules if objects are supposed to be inthe package. package_a Context: Object(s) '['PackageASubpackageObject']' from module package_a was mocked out during packaging but is being used in resource - obj.pkl in package obj. package_a.subpackage Context: Object(s) '['PackageASubpackageObject']' from module package_a.subpackage was mocked out during packaging but is being used in resource - obj.pkl in package obj. ``` This makes it significantly easier to fix mocked object errors as they all should appear at once. Test Plan: Imported from OSS Reviewed By: d4l3k Differential Revision: D34951973 Pulled By: PaliC fbshipit-source-id: 01ee4ba3767967ef9a9bcd69ad86362ebc100b2d (cherry picked from commit 900edd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Now instead of spitting out a NotImplemented Error when the Package Exporter finds an object for a mocked module, it combines these errors with the rest of the Packaging Errors of PackageExporter to get something like
This makes it significantly easier to fix mocked object errors as they all should appear at once.
Differential Revision: D34951973