[PyTorch Distributed] Move NCCL_DEBUG print to after NCCL init #74287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwen2501
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 10289a9 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34912492 |
facebook-github-bot
added
the
oncall: distributed
…ch#74287) Summary: Pull Request resolved: pytorch#74287 NCCL may read env vars from nccl.conf, it would be more accurate to get envs after NCCL inits Test Plan: unit test Reviewed By: ajauhri Differential Revision: D34912492 fbshipit-source-id: fe43bd66eec7bbec9987f77f68714a48e1309737
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34912492 |
kwen2501
force-pushed
the
export-D34912492
branch
from
da9aa65 to
10289a9
Compare
Comment on lines
+1165
to
+1167
| if (getRank() == 0) { | ||
| LOG(INFO) << "NCCL_DEBUG: " << parse_env("NCCL_DEBUG"); | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't we print this on all ranks? The log above "ProcessGroupNCCL initialized with following options" is printed on all ranks.
Collaborator
Author
There was a problem hiding this comment.
It is more for verbosity consideration - not sure if a user wants 1000 lines of NCCL_DEBUG=INFO printed in the log. The other options, by contrast, need to be consistent across all ranks, otherwise there would be a hang. So there may still a value in printing them on all ranks. Although, I am happy to simplify those as well :)
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
Summary: Pull Request resolved: #74287 NCCL may read env vars from nccl.conf, it would be more accurate to get envs after NCCL inits Test Plan: unit test Reviewed By: ajauhri Differential Revision: D34912492 fbshipit-source-id: d794935573a59fd25f8cbfde6b64978e063e4d7a
Contributor
|
Hey @kwen2501. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NCCL may read env vars from nccl.conf, it would be more accurate to get
envs after NCCL inits
Test Plan: unit test
Differential Revision: D34912492