[torch::deploy] Replace ArrayRef with local implementation to torch::deploy #74286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit aa0f879 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34907002 |
Summary: Remove `c10::errors` from torch::deploy and replace them with `multipy::errors` which is effectively a wrapper around `std::runtime_error Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Differential Revision: D34905174 fbshipit-source-id: e8bd9917fbe1f835b9136201c0a348268088d6d1
…rch#74286) Summary: Pull Request resolved: pytorch#74286 This diff replaces `c10::optional` with the implementation it's based on in https://github.com/akrzemi1/Optional in order to help torch::deploy function without a dependency on `torch` pytorch#74002 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Reviewed By: d4l3k Differential Revision: D34907002 fbshipit-source-id: a9edd980091a65196c4a6cd1899e6bee2099c6ee
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34907002 |
PaliC
pushed a commit
to PaliC/pytorch
that referenced
this pull request
Mar 16, 2022
…rch#74286) Summary: Pull Request resolved: pytorch#74286 This diff replaces `c10::optional` with the implementation it's based on in https://github.com/akrzemi1/Optional in order to help torch::deploy function without a dependency on `torch` pytorch#74002 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Differential Revision: D34907002 fbshipit-source-id: 1064a93f8bbedb3bed6b8fd1f5275a55698410b2
PaliC
pushed a commit
to PaliC/pytorch
that referenced
this pull request
Mar 16, 2022
…rch#74286) Summary: Pull Request resolved: pytorch#74286 This diff replaces `c10::optional` with the implementation it's based on in https://github.com/akrzemi1/Optional in order to help torch::deploy function without a dependency on `torch` pytorch#74002 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Differential Revision: D34907002 fbshipit-source-id: be019f70b3d0f877f5b4e6a7074032a2826b6a88
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74286 This diff replaces `c10::optional` with the implementation it's based on in https://github.com/akrzemi1/Optional in order to help torch::deploy function without a dependency on `torch` #74002 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Reviewed By: d4l3k Differential Revision: D34907002 fbshipit-source-id: 93a3386f43d1c426f23c6dab5f898ed63b547a5c
Contributor
|
Hey @PaliC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff replaces
c10::optionalwith the implementation it's based on in https://github.com/akrzemi1/Optionalin order to help torch::deploy function without a dependency on
torch#74002
Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy
Differential Revision: D34907002