[torch::deploy] Remove c10::errors from torch::deploy
#74283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8e017a1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34905174 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34905174 |
Summary: Pull Request resolved: pytorch#74283 Remove `c10::errors` from torch::deploy and replace them with `multipy::errors` which is effectively a wrapper around `std::runtime_error. Review History can be found with pytorch#73456 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Differential Revision: D34905174 fbshipit-source-id: 528d9b3a010360645c669efa3c7852d7ae5e649c
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34905174 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74283 Remove `c10::errors` from torch::deploy and replace them with `multipy::errors` which is effectively a wrapper around `std::runtime_error. Review History can be found with #73456 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Reviewed By: aivanou Differential Revision: D34905174 fbshipit-source-id: 8883fc77dce66c489fa3fa9d14a71d1de1e0cc5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove
c10::errorsfrom torch::deploy and replace them withmultipy::errorswhich is effectively a wrapper around `std::runtime_error.Review History can be found with #73456
Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy
Differential Revision: D34905174