Change ShardedTensor torch_function to be a classmethod. #74273

pritamdamania87 · 2022-03-16T01:08:26Z

Stack from ghstack (oldest at bottom):

-> Change ShardedTensor torch_function to be a classmethod. #74273

As per discussion in #63767,
torch_function should be a classmethod and instance method based
implementations would be deprecated soon.

As a result, making this a classmethod and using the suggestion in
#63767 to find the ShardedTensor
instance in the args/kwargs.

Differential Revision: D34913799

As per discussion in #63767, torch_function should be a classmethod and instance method based implementations would be deprecated soon. As a result, making this a classmethod and using the suggestion in #63767 to find the ShardedTensor instance in the args/kwargs. Differential Revision: [D34913799](https://our.internmc.facebook.com/intern/diff/D34913799/) [ghstack-poisoned]

pytorch-bot · 2022-03-16T01:08:30Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/637c65e79bfacad80f54ac8df32603c71dce4883/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-binary-manywheel	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
windows-binary-libtorch-debug	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
windows-binary-libtorch-release	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
windows-binary-wheel	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`, `ciflow/trunk`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-bionic-rocm4.5-py3.7-distributed	`ciflow/all`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	🚫 skipped

facebook-github-bot · 2022-03-16T01:08:30Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/74273
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 637c65e (more details on the Dr. CI page):

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-xenial-cuda11.3-py3.7-gcc7 / build (1/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-16T01:10:29.2221564Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m

2022-03-16T01:10:29.2218367Z �[36;1mfi�[0m
2022-03-16T01:10:29.2218638Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-16T01:10:29.2219003Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-16T01:10:29.2219356Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-16T01:10:29.2219762Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-16T01:10:29.2220091Z �[36;1m  exit 1�[0m
2022-03-16T01:10:29.2220281Z �[36;1mfi�[0m
2022-03-16T01:10:29.2220541Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-16T01:10:29.2220878Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-16T01:10:29.2221212Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-16T01:10:29.2221564Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-16T01:10:29.2221928Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-16T01:10:29.2222170Z �[36;1m  exit 1�[0m
2022-03-16T01:10:29.2222361Z �[36;1mfi�[0m
2022-03-16T01:10:29.2222584Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-16T01:10:29.2233504Z shell: /usr/bin/bash -e {0}
2022-03-16T01:10:29.2233717Z env:
2022-03-16T01:10:29.2233961Z   BUILD_ENVIRONMENT: linux-xenial-cuda11.3-py3.7-gcc7
2022-03-16T01:10:29.2234372Z   DOCKER_IMAGE_BASE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7
2022-03-16T01:10:29.2234774Z   SCCACHE_BUCKET: ossci-compiler-cache-circleci-v2
2022-03-16T01:10:29.2235195Z   XLA_CLANG_CACHE_S3_BUCKET_NAME: ossci-compiler-clang-cache-circleci-xla

Lint / clang-tidy (2/2)

Step: "Check for warnings" (full log | diagnosis details | 🔁 rerun)

2022-03-16T01:14:26.6064715Z /__w/pytorch/pytor...ng-diagnostic-unused-variable,-warnings-as-errors]

2022-03-16T01:14:26.3867490Z �[36;1mset -eu�[0m
2022-03-16T01:14:26.3868100Z �[36;1mcat "${GITHUB_WORKSPACE}"/clang-tidy-output.txt�[0m
2022-03-16T01:14:26.3868977Z �[36;1mif grep -Fq "Warnings detected!" "${GITHUB_WORKSPACE}"/clang-tidy-output.txt; then�[0m
2022-03-16T01:14:26.3869841Z �[36;1m  echo 'Please fix the above clang-tidy warnings.'�[0m
2022-03-16T01:14:26.3870422Z �[36;1m  false�[0m
2022-03-16T01:14:26.3870837Z �[36;1mfi�[0m
2022-03-16T01:14:26.3871359Z shell: sh -e {0}
2022-03-16T01:14:26.3871821Z ##[endgroup]
2022-03-16T01:14:26.6063393Z No files detected
2022-03-16T01:14:26.6063986Z Processing 45 clang-tidy jobs
2022-03-16T01:14:26.6064715Z /__w/pytorch/pytorch/torch/csrc/deploy/interpreter/builtin_registry.cpp:93:7: error: unused variable 'r' [clang-diagnostic-unused-variable,-warnings-as-errors]
2022-03-16T01:14:26.6065371Z   int r = PyRun_SimpleString(metaPathSetupScript.c_str());
2022-03-16T01:14:26.6065660Z       ^
2022-03-16T01:14:26.6065883Z Warnings detected!
2022-03-16T01:14:26.6066094Z Summary:
2022-03-16T01:14:26.6066494Z [clang-diagnostic-unused-variable] occurred 1 times
2022-03-16T01:14:26.6108255Z     /__w/pytorch/pytorch/torch/csrc/deploy/interpreter/builtin_registry.cpp:93
2022-03-16T01:14:26.6108628Z 
2022-03-16T01:14:26.6109025Z Please fix the above clang-tidy warnings.
2022-03-16T01:14:26.6116732Z ##[error]Process completed with exit code 1.
2022-03-16T01:14:26.6160111Z ##[group]Run pytorch/add-annotations-github-action@master

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

As per discussion in #63767, torch_function should be a classmethod and instance method based implementations would be deprecated soon. As a result, making this a classmethod and using the suggestion in #63767 to find the ShardedTensor instance in the args/kwargs. Differential Revision: [D34913799](https://our.internmc.facebook.com/intern/diff/D34913799/) ghstack-source-id: 151463383 Pull Request resolved: #74273

wanchaol

lgtm, thanks for fixing it!

Summary: Pull Request resolved: #74273 As per discussion in #63767, torch_function should be a classmethod and instance method based implementations would be deprecated soon. As a result, making this a classmethod and using the suggestion in #63767 to find the ShardedTensor instance in the args/kwargs. ghstack-source-id: 151463383 Test Plan: waitforbuildbot Reviewed By: wanchaol Differential Revision: D34913799 fbshipit-source-id: c2f95ace861b118ea539215188d8723316cbb066

github-actions · 2022-03-17T21:04:59Z

Hey @pritamdamania87.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: #74273 As per discussion in #63767, torch_function should be a classmethod and instance method based implementations would be deprecated soon. As a result, making this a classmethod and using the suggestion in #63767 to find the ShardedTensor instance in the args/kwargs. ghstack-source-id: 151463383 Test Plan: waitforbuildbot Reviewed By: wanchaol Differential Revision: D34913799 fbshipit-source-id: c2f95ace861b118ea539215188d8723316cbb066 (cherry picked from commit 1806664)

pritamdamania87 requested review from H-Huang, mingzhe09088, mrshenli, rohan-varma and zhaojuanmao as code owners March 16, 2022 01:08

pytorch-bot bot added the ciflow/default label Mar 16, 2022

facebook-github-bot added the cla signed label Mar 16, 2022

facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Mar 16, 2022

wanchaol approved these changes Mar 17, 2022

View reviewed changes

pytorchmergebot closed this in 6ffe166 Mar 17, 2022

facebook-github-bot deleted the gh/pritamdamania87/225/head branch March 21, 2022 14:17

pritamdamania87 added release notes: distributed (sharded) release notes category topic: not user facing topic category labels Mar 21, 2022

josiahls mentioned this pull request May 8, 2022

torch_core __torch_function__ breaks on downstream pytorch fastai/fastai#3638

Closed

WBobby mentioned this pull request Aug 17, 2022

Add ROCm5.2.3/AMDGPU support for PyTorch WBobby/pytorch#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change ShardedTensor torch_function to be a classmethod. #74273

Change ShardedTensor torch_function to be a classmethod. #74273

Uh oh!

pritamdamania87 commented Mar 16, 2022 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 16, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Mar 16, 2022 •

edited

Loading

Uh oh!

wanchaol left a comment

Uh oh!

github-actions bot commented Mar 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Change ShardedTensor torch_function to be a classmethod. #74273

Change ShardedTensor torch_function to be a classmethod. #74273

Uh oh!

Conversation

pritamdamania87 commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 16, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

linux-xenial-cuda11.3-py3.7-gcc7 / build (1/2)

Lint / clang-tidy (2/2)

Uh oh!

wanchaol left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pritamdamania87 commented Mar 16, 2022 •

edited

Loading

facebook-github-bot commented Mar 16, 2022 •

edited

Loading