[Static Runtime] Fix a bug that aten::full_like reuses a tensor that does not match arguments
#74255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
facebook-github-bot
added
the
oncall: jit
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 4d1864e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34863639 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34863639 |
d1jang
force-pushed
the
export-D34863639
branch
from
12d709f to
46b8834
Compare
…t does not match arguments (pytorch#74255) Summary: Pull Request resolved: pytorch#74255 This change fixes a bug that `aten::full_like` reuses a previously allocated tensor that does not match requested one when arguments to `aten::full_like` are dynamically changed. Test Plan: - Enhanced `StaticRuntime.FullLike` to cover the modified code path. Reviewed By: mikeiovine Differential Revision: D34863639 fbshipit-source-id: 8ceffe240978b211963826ffcb8c1f693109017e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34863639 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
…t does not match arguments (#74255) Summary: Pull Request resolved: #74255 This change fixes a bug that `aten::full_like` reuses a previously allocated tensor that does not match requested one when arguments to `aten::full_like` are dynamically changed. Test Plan: - Enhanced `StaticRuntime.FullLike` to cover the modified code path. Reviewed By: mikeiovine Differential Revision: D34863639 fbshipit-source-id: ca6d4ee3c039e263cc3a4f643d949cea59381608
Contributor
|
Hey @d1jang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This change fixes a bug that
aten::full_likereuses a previously allocated tensor that does not match requested one when arguments toaten::full_likeare dynamically changed.Test Plan: - Enhanced
StaticRuntime.FullLiketo cover the modified code path.Reviewed By: mikeiovine
Differential Revision: D34863639