-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Excluding ASAN and periodic jobs from slow job calculation #74253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit a22d5c6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
janeyx99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Should we rebase this PR? Looks like there's a lot of failing signal here |
Done! |
malfet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please rebase on the stable branch
|
@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Mitigates #72368 As per discussion here #72368 Some ASAN tests take much longer then same tests that not run under ASAN: ``` test_fn_gradgrad_pca_lowrank_cpu_float64 (__main__.TestGradientsCPU) ... ok (60.780s) test_fn_gradgrad_svd_cpu_complex128 (__main__.TestGradientsCPU) ... ok (69.131s) test_inplace_gradgrad_cumprod_cpu_complex128 (__main__.TestGradientsCPU) ... ok (211.554s) test_variant_consistency_jit_diff_cpu_complex64 (__main__.TestJitCPU) ... ok (67.640s) 2022-03-12T21:46:25.3026906Z test_variant_consistency_jit_linalg_solve_triangular_cpu_float32 (__main__.TestJitCPU) ... ok (125.208s) 2022-03-12T21:48:58.0469092Z test_variant_consistency_jit_linalg_svd_cpu_complex64 (__main__.TestJitCPU) ... ok (152.744s) 2022-03-12T21:50:11.6688335Z test_variant_consistency_jit_linalg_svd_cpu_float32 (__main__.TestJitCPU) ... ok (73.622s) 2022-03-12T21:54:44.5263321Z test_variant_consistency_jit_lu_solve_cpu_complex64 (__main__.TestJitCPU) ... ok (102.051s) 2022-03-12T21:55:35.6167891Z test_variant_consistency_jit_lu_solve_cpu_float32 (__main__.TestJitCPU) ... ok (51.090s) 2022-03-12T22:00:58.4220662Z test_variant_consistency_jit_nanquantile_cpu_float32 (__main__.TestJitCPU) ... ok (47.142s) 2022-03-12T22:12:25.8979944Z test_variant_consistency_jit_nn_functional_max_pool1d_cpu_float32 (__main__.TestJitCPU) ... ok (494.579s) 2022-03-12T22:32:45.9750642Z test_variant_consistency_jit_nn_functional_max_pool2d_cpu_float32 (__main__.TestJitCPU) ... ok (1220.077s) 2022-03-12T22:40:31.3121960Z test_variant_consistency_jit_nn_functional_max_pool3d_cpu_float32 (__main__.TestJitCPU) ... ok (465.337s) 2022-03-12T22:41:56.5711967Z test_variant_consistency_jit_nn_functional_pad_circular_cpu_complex64 (__main__.TestJitCPU) ... ok (58.542s) 2022-03-12T22:45:48.7048047Z test_variant_consistency_jit_nn_functional_pad_constant_cpu_complex64 (__main__.TestJitCPU) ... ok (232.128s) 2022-03-12T22:47:49.1422719Z test_variant_consistency_jit_nn_functional_pad_constant_cpu_float32 (__main__.TestJitCPU) ... ok (120.437s) 2022-03-12T22:48:48.9686822Z test_variant_consistency_jit_nn_functional_pad_reflect_cpu_complex64 (__main__.TestJitCPU) ... ok (59.826s) 2022-03-12T22:49:49.2502012Z test_variant_consistency_jit_nn_functional_pad_replicate_cpu_complex64 (__main__.TestJitCPU) ... ok (60.272s) 2022-03-12T22:51:02.5255728Z test_variant_consistency_jit_nn_functional_poisson_nll_loss_cpu_float32 (__main__.TestJitCPU) ... ok (73.208s) 2022-03-12T22:54:23.8291811Z test_variant_consistency_jit_norm_cpu_complex64 (__main__.TestJitCPU) ... ok (136.107s) 2022-03-12T22:55:33.0800761Z test_variant_consistency_jit_norm_cpu_float32 (__main__.TestJitCPU) ... ok (69.251s) 2022-03-12T22:57:50.4699741Z test_variant_consistency_jit_ormqr_cpu_complex64 (__main__.TestJitCPU) ... ok (105.720s) 2022-03-12T22:58:46.2191192Z test_variant_consistency_jit_ormqr_cpu_float32 (__main__.TestJitCPU) ... ok (55.749s) 2022-03-12T23:01:40.5424782Z test_variant_consistency_jit_prod_cpu_complex64 (__main__.TestJitCPU) ... ok (89.440s) 2022-03-12T23:03:20.2300845Z test_variant_consistency_jit_put_cpu_complex64 (__main__.TestJitCPU) ... ok (55.004s) 2022-03-12T23:05:34.2481242Z test_variant_consistency_jit_qr_cpu_complex64 (__main__.TestJitCPU) ... ok (106.490s) 2022-03-12T23:06:26.1268335Z test_variant_consistency_jit_qr_cpu_float32 (__main__.TestJitCPU) ... ok (51.879s) 2022-03-12T23:07:51.5261184Z test_variant_consistency_jit_quantile_cpu_float32 (__main__.TestJitCPU) ... ok (85.399s) test_variant_consistency_jit_sort_cpu_float32 (__main__.TestJitCPU) ... ok (84.378s) 2022-03-12T23:23:48.6314435Z test_variant_consistency_jit_sum_cpu_complex64 (__main__.TestJitCPU) ... ok (55.706s) 2022-03-12T23:24:19.2219967Z test_variant_consistency_jit_sum_cpu_float32 (__main__.TestJitCPU) ... ok (30.590s) 2022-03-12T23:36:45.9809917Z test_variant_consistency_jit_svd_cpu_complex64 (__main__.TestJitCPU) ... ok (746.744s) 2022-03-12T23:42:42.7827088Z test_variant_consistency_jit_svd_cpu_float32 (__main__.TestJitCPU) ... ok (356.802s) 2022-03-12T23:47:12.7248896Z test_variant_consistency_jit_tile_cpu_complex64 (__main__.TestJitCPU) ... ok (85.721s) ``` ------------- This PR ignores ASAN and periodic job for slow job calculation. Tested by printing the matched jobs rather then continue: ``` python export_slow_test.py Overwriting existent file: .pytorch-slow-tests.json linux-xenial-py3.7-clang7-asan-test linux-xenial-py3.7-clang7-asan-test linux-xenial-py3.7-clang7-asan-test periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck-test periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck-test ``` Pull Request resolved: #74253 Reviewed By: janeyx99 Differential Revision: D34906097 Pulled By: atalman fbshipit-source-id: 48103f970e0c4e8683aebd8f78b7d7546fdb35d4
|
Hey @atalman. |
Mitigates #72368
As per discussion here #72368
Some ASAN tests take much longer then same tests that not run under ASAN:
This PR ignores ASAN and periodic job for slow job calculation.
Tested by printing the matched jobs rather then continue: