[reland][quant] Fix implementation for output_quantized_idxs in convert (#74140)
#74229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4140) Summary: Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) since we called dead code elimination pass, some of the inplace operators are removed in the TestQuantizeFx.test_fixed_qparams_ops, in this PR we also just removed the calls to the inplace ops, and changed the expected results in the test case, in the future PR we can remove the support for inplace operators, since it is not really supported in fx, and it's OK for us to skip them as well Reviewed By: andrewor14 (cherry picked from commit 682abe9) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e340132 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jerryzh168
added a commit
that referenced
this pull request
Mar 15, 2022
…4140) Summary: Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) since we called dead code elimination pass, some of the inplace operators are removed in the TestQuantizeFx.test_fixed_qparams_ops, in this PR we also just removed the calls to the inplace ops, and changed the expected results in the test case, in the future PR we can remove the support for inplace operators, since it is not really supported in fx, and it's OK for us to skip them as well Reviewed By: andrewor14 (cherry picked from commit 682abe9) ghstack-source-id: 2368a69 Pull Request resolved: #74229
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
changed the title
output_quantized_idxs in convert (#74140)output_quantized_idxs in convert (#74140)
vkuzo
approved these changes
Mar 15, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
…4140) (#74229) Summary: Pull Request resolved: #74229 Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) since we called dead code elimination pass, some of the inplace operators are removed in the TestQuantizeFx.test_fixed_qparams_ops, in this PR we also just removed the calls to the inplace ops, and changed the expected results in the test case, in the future PR we can remove the support for inplace operators, since it is not really supported in fx, and it's OK for us to skip them as well Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D34888140 fbshipit-source-id: 48cea842b49e52baa8eee3ce0f4bfb4a3625ab2a
Contributor
|
Hey @jerryzh168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
output_quantized_idxsin convert (#74140) #74229Summary:
Previously we did not successfully remove the dequantize node for
dict, this PR fixes that, tested withmeta-only tests right now but we should follow up with oss tests (with dict output)
since we called dead code elimination pass, some of the inplace operators are removed in the TestQuantizeFx.test_fixed_qparams_ops,
in this PR we also just removed the calls to the inplace ops, and changed the expected results in the test case,
in the future PR we can remove the support for inplace operators, since it is not really supported in fx, and it's OK
for us to skip them as well
Reviewed By: andrewor14
(cherry picked from commit 682abe9)
Differential Revision: D34888140