Skip to content

Conversation

@awgu
Copy link
Collaborator

@awgu awgu commented Mar 15, 2022

Stack from ghstack:

Differential Revision: D35045122

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 15, 2022

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/5348e1d588bcb47fa597ebc9a06cb78a4207c627/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
linux-binary-libtorch-cxx11-abi ciflow/all, ciflow/binaries, ciflow/binaries_libtorch, ciflow/default, ciflow/trunk ✅ triggered
linux-binary-libtorch-pre-cxx11 ciflow/all, ciflow/binaries, ciflow/binaries_libtorch, ciflow/default, ciflow/trunk ✅ triggered
linux-binary-manywheel ciflow/all, ciflow/binaries, ciflow/binaries_wheel, ciflow/default, ciflow/trunk ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-bionic-rocm4.5-py3.7 ciflow/all, ciflow/default, ciflow/linux, ciflow/rocm, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build ciflow/all, ciflow/cpu, ciflow/default, ciflow/libtorch, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
macos-arm64-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-arm64-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
macos-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
windows-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
windows-binary-libtorch-debug ciflow/all, ciflow/binaries, ciflow/binaries_libtorch, ciflow/default, ciflow/trunk ✅ triggered
windows-binary-libtorch-release ciflow/all, ciflow/binaries, ciflow/binaries_libtorch, ciflow/default, ciflow/trunk ✅ triggered
windows-binary-wheel ciflow/all, ciflow/binaries, ciflow/binaries_wheel, ciflow/default, ciflow/trunk ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-bionic-rocm4.5-py3.7-distributed ciflow/all, ciflow/linux, ciflow/rocm, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk, ciflow/xla 🚫 skipped

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 15, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit bbfbae2 (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build pull / linux-docs / build-docs (python) (1/1)

Step: "Build python docs" (full log | diagnosis details | 🔁 rerun)

2022-03-26T23:30:20.5090916Z Makefile:38: recipe for target 'html' failed
2022-03-26T23:30:19.0324736Z copying images... [ 92%] _static/img/tensorboard/add_histogram.png
2022-03-26T23:30:19.0326658Z copying images... [ 95%] _static/img/tensorboard/add_image.png
2022-03-26T23:30:19.0329097Z copying images... [ 97%] _static/img/tensorboard/add_images.png
2022-03-26T23:30:19.0331564Z copying images... [100%] _static/img/tensorboard/add_hparam.png
2022-03-26T23:30:19.0333401Z 
2022-03-26T23:30:19.0630614Z copying static files... done
2022-03-26T23:30:19.0631436Z copying extra files... done
2022-03-26T23:30:19.5069152Z dumping search index in English (code: en)... done
2022-03-26T23:30:19.6036636Z dumping object inventory... done
2022-03-26T23:30:19.6036912Z build finished with problems, 1 warning.
2022-03-26T23:30:20.5090916Z Makefile:38: recipe for target 'html' failed
2022-03-26T23:30:20.5091267Z make[1]: *** [html] Error 1
2022-03-26T23:30:20.5091640Z make[1]: Leaving directory '/var/lib/jenkins/workspace/docs'
2022-03-26T23:30:20.5092236Z Makefile:27: recipe for target 'html-stable' failed
2022-03-26T23:30:20.5092813Z make: *** [html-stable] Error 2
2022-03-26T23:30:20.5094150Z ++ code=2
2022-03-26T23:30:20.5094439Z ++ '[' 2 -ne 0 ']'
2022-03-26T23:30:20.5094643Z ++ set +x
2022-03-26T23:30:20.5094805Z =========================
2022-03-26T23:30:20.5122783Z /opt/conda/lib/python3.7/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py:docstring of torch.distributed.fsdp.fully_sharded_data_parallel.FullyShardedDataParallel.state_dict_type:11: WARNING: Explicit markup ends without a blank line; unexpected unindent.
2022-03-26T23:30:20.5123695Z =========================

2 failures not recognized by patterns:

Job Step Action
GitHub Actions pull / linux-docs / build-docs (cpp) Unknown 🔁 rerun
GitHub Actions pull / linux-xenial-py3.7-gcc5.4 / test (docs_test, 1, 1, linux.2xlarge) Test 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Mar 15, 2022
@awgu awgu mentioned this pull request Mar 15, 2022
4 tasks
Copy link
Contributor

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving our documentation!

@awgu awgu marked this pull request as ready for review March 16, 2022 21:00
Andrew Gu added 2 commits March 17, 2022 19:43
@awgu
Copy link
Collaborator Author

awgu commented Mar 22, 2022

@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

awgu pushed a commit to awgu/pytorch that referenced this pull request Mar 24, 2022
ghstack-source-id: 4f33833
Pull Request resolved: pytorch#74214
@awgu
Copy link
Collaborator Author

awgu commented Mar 25, 2022

@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

2 similar comments
@awgu
Copy link
Collaborator Author

awgu commented Mar 25, 2022

@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@awgu
Copy link
Collaborator Author

awgu commented Mar 26, 2022

@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@awgu
Copy link
Collaborator Author

awgu commented Mar 26, 2022

@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2022
Summary: Pull Request resolved: #74214

Test Plan: Imported from OSS

Reviewed By: saketh-are

Differential Revision: D35045122

Pulled By: awgu

fbshipit-source-id: 701181cfdb93cb4ebf8e036a9f5c118f38005d6d
@github-actions
Copy link
Contributor

Hey @awgu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@janeyx99
Copy link
Contributor

Reverting--broke docs job as can be seen in PR CI as well. Please make sure the docs job passes when relanding this PR.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 47acdfa. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

awgu pushed a commit that referenced this pull request Mar 28, 2022
Reland of #74214.
Includes fixing #74694.

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Mar 28, 2022
Reland of #74214.
Includes fixing #74694.

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Mar 28, 2022
Reland of #74214.
Includes fixing #74694.

Differential Revision: [D35188146](https://our.internmc.facebook.com/intern/diff/D35188146)

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Mar 28, 2022
Reland of #74214.
Includes fixing #74694.

Differential Revision: [D35188146](https://our.internmc.facebook.com/intern/diff/D35188146)

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Mar 29, 2022
Reland of #74214.
Includes fixing #74694.

Differential Revision: [D35188146](https://our.internmc.facebook.com/intern/diff/D35188146)

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Mar 29, 2022
Reland of #74214.
Includes fixing #74694.

Differential Revision: [D35188146](https://our.internmc.facebook.com/intern/diff/D35188146)

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Mar 29, 2022
Reland of #74214.
Includes fixing #74694.

Differential Revision: [D35188146](https://our.internmc.facebook.com/intern/diff/D35188146)

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Mar 29, 2022
Reland of #74214.
Includes fixing #74694.

Differential Revision: [D35188146](https://our.internmc.facebook.com/intern/diff/D35188146)

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Mar 29, 2022
Summary:
Pull Request resolved: #74834

Reland of #74214.
Includes fixing #74694.

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D35188146

Pulled By: awgu

fbshipit-source-id: fbb1a2f22a2121f39cdb2fae3519a9d135b298f7
(cherry picked from commit 710beed)
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 47acdfa. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants