[ATen][AMD] revert a change of USE_DIRECT_NVRTC #74194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0a0ca6c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34564267 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34564267 |
shintaro-iwasaki
force-pushed
the
export-D34564267
branch
from
609030d to
f9619ad
Compare
Summary: Pull Request resolved: pytorch#74194 This patch reverts a change of `USE_DIRECT_NVRTC` in pytorch#71925. Note that `USE_DIRECT_NVRTC` is used only internally (i.e., it is always undefined for OSS compilation) as far as I checked, so this change should not affect any OSS build. Test Plan: CI Reviewed By: jianyuh Differential Revision: D34564267 fbshipit-source-id: eac1c3a9b451832ef83e95f527a2fe24ca797fb4
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34564267 |
shintaro-iwasaki
force-pushed
the
export-D34564267
branch
from
f9619ad to
0a0ca6c
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74194 This patch reverts a change of `USE_DIRECT_NVRTC` in #71925. Note that `USE_DIRECT_NVRTC` is used only internally (i.e., it is always undefined for OSS compilation) as far as I checked, so this change should not affect any OSS build. Test Plan: CI Reviewed By: jianyuh Differential Revision: D34564267 fbshipit-source-id: dac3333aeae87d1a3daa3fc5ebbde06e5260d3a4
Contributor
|
Hey @shintaro-iwasaki. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This patch reverts a change of
USE_DIRECT_NVRTCin #71925. Note thatUSE_DIRECT_NVRTCis used only internally (i.e., it is always undefined for OSS compilation) as far as I checked, so this change should not affect any OSS build.Test Plan: CI
Differential Revision: D34564267