[quant] Fix implementation for output_quantized_idxs in convert
#74140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit a4a1b36 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34846005 |
andrewor14
approved these changes
Mar 14, 2022
…torch#74140) Summary: Pull Request resolved: pytorch#74140 Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) Reviewed By: andrewor14 Differential Revision: D34846005 fbshipit-source-id: 5988a9e3f167d81b8f5c5b097bb24b0e52cbab7a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34846005 |
jerryzh168
force-pushed
the
export-D34846005
branch
from
753f2b0 to
a4a1b36
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
…4140) Summary: Pull Request resolved: #74140 Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) Reviewed By: andrewor14 Differential Revision: D34846005 fbshipit-source-id: 4313ed6adff425d73ad19aabedde1200a98f1915
Contributor
|
Hey @jerryzh168. |
Contributor
|
This pull request has been reverted by 1e64c8a. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Contributor
|
@jerryzh168 this PR broke number of tests and also were red on PR CI. Why was it landed? |
jerryzh168
added a commit
that referenced
this pull request
Mar 15, 2022
…4140) Summary: Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) since we called dead code elimination pass, some of the inplace operators are removed in the TestQuantizeFx.test_fixed_qparams_ops, in this PR we also just removed the calls to the inplace ops, and changed the expected results in the test case, in the future PR we can remove the support for inplace operators, since it is not really supported in fx, and it's OK for us to skip them as well Reviewed By: andrewor14 (cherry picked from commit 682abe9) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 15, 2022
…4140) Summary: Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) since we called dead code elimination pass, some of the inplace operators are removed in the TestQuantizeFx.test_fixed_qparams_ops, in this PR we also just removed the calls to the inplace ops, and changed the expected results in the test case, in the future PR we can remove the support for inplace operators, since it is not really supported in fx, and it's OK for us to skip them as well Reviewed By: andrewor14 (cherry picked from commit 682abe9) ghstack-source-id: 2368a69 Pull Request resolved: #74229
Contributor
Author
|
I think I forgot to export the diff to github, also the test errors in phabricator looks irrelevant |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
…4140) (#74229) Summary: Pull Request resolved: #74229 Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) since we called dead code elimination pass, some of the inplace operators are removed in the TestQuantizeFx.test_fixed_qparams_ops, in this PR we also just removed the calls to the inplace ops, and changed the expected results in the test case, in the future PR we can remove the support for inplace operators, since it is not really supported in fx, and it's OK for us to skip them as well Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D34888140 fbshipit-source-id: 48cea842b49e52baa8eee3ce0f4bfb4a3625ab2a
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 16, 2022
…4140) (#74229) Summary: Pull Request resolved: #74229 Previously we did not successfully remove the dequantize node for `dict`, this PR fixes that, tested with meta-only tests right now but we should follow up with oss tests (with dict output) since we called dead code elimination pass, some of the inplace operators are removed in the TestQuantizeFx.test_fixed_qparams_ops, in this PR we also just removed the calls to the inplace ops, and changed the expected results in the test case, in the future PR we can remove the support for inplace operators, since it is not really supported in fx, and it's OK for us to skip them as well Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D34888140 fbshipit-source-id: 48cea842b49e52baa8eee3ce0f4bfb4a3625ab2a (cherry picked from commit ef79031)
Contributor
|
This pull request has been reverted by 1e64c8a. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously we did not successfully remove the dequantize node for
dict, this PR fixes that, tested withmeta-only tests right now but we should follow up with oss tests (with dict output)
Differential Revision: D34846005