[DDP] Generalize activation checkpoint tests #74130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable these tests to run for all dist backends not just nccl. Differential Revision: [D34281684](https://our.internmc.facebook.com/intern/diff/D34281684/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c809226 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
CI Flow Status⚛️ CI FlowRuleset - Version:
|
facebook-github-bot
added
cla signed
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Mar 11, 2022
enable these tests to run for all dist backends not just nccl. Differential Revision: [D34281684](https://our.internmc.facebook.com/intern/diff/D34281684/) ghstack-source-id: 151201192 Pull Request resolved: #74130
- Enables activation checkpointing tests to run for GLOO backend in addition to NCCL. - Follow up changes will add support for non reentrant-based checkpointing and CheckpointWrapper. - Differential Revision: [D34281684](https://our.internmc.facebook.com/intern/diff/D34281684/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Mar 12, 2022
Pull Request resolved: #74130 enable these tests to run for all dist backends not just nccl. ghstack-source-id: 151220384 Differential Revision: [D34281684](https://our.internmc.facebook.com/intern/diff/D34281684/)
- Enables activation checkpointing tests to run for GLOO backend in addition to NCCL. - Follow up changes will add support for non reentrant-based checkpointing and CheckpointWrapper. - Differential Revision: [D34281684](https://our.internmc.facebook.com/intern/diff/D34281684/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Mar 14, 2022
Pull Request resolved: #74130 enable these tests to run for all dist backends not just nccl. ghstack-source-id: 151275305 Differential Revision: [D34281684](https://our.internmc.facebook.com/intern/diff/D34281684/)
awgu
reviewed
Mar 15, 2022
Collaborator
awgu
left a comment
awgu
left a comment
There was a problem hiding this comment.
Left some minor questions.
- Enables activation checkpointing tests to run for GLOO backend in addition to NCCL. - Follow up changes will add support for non reentrant-based checkpointing and CheckpointWrapper. - Changes AbstractDDPTest to CommonDDPTest to better indicate that it now has tests that are common to both backends - Differential Revision: [D34281684](https://our.internmc.facebook.com/intern/diff/D34281684/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Mar 15, 2022
Test wasn't actually doing weight sharing as pointed out by Andrew in #74130 (comment) Differential Revision: [D34904535](https://our.internmc.facebook.com/intern/diff/D34904535/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Mar 15, 2022
Test wasn't actually doing weight sharing as pointed out by Andrew in #74130 (comment) Differential Revision: [D34904535](https://our.internmc.facebook.com/intern/diff/D34904535/) ghstack-source-id: 151429409 Pull Request resolved: #74252
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74130 enable these tests to run for all dist backends not just nccl. ghstack-source-id: 151429410 Test Plan: CI Reviewed By: awgu Differential Revision: D34281684 fbshipit-source-id: 956c1b0cafe0502b593dd42b157d518e89a47d8e
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74252 Test wasn't actually doing weight sharing as pointed out by Andrew in #74130 (comment) ghstack-source-id: 151429409 Test Plan: CI Reviewed By: awgu Differential Revision: D34904535 fbshipit-source-id: 62d1aa9d9fd618176ecd898ca9364a6fa478be6d
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74252 Test wasn't actually doing weight sharing as pointed out by Andrew in #74130 (comment) ghstack-source-id: 151429409 Test Plan: CI Reviewed By: awgu Differential Revision: D34904535 fbshipit-source-id: 62d1aa9d9fd618176ecd898ca9364a6fa478be6d (cherry picked from commit 03e7b3b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D34281684