[Reducer] small fix #74127

rohan-varma · 2022-03-11T22:36:17Z

Stack from ghstack (oldest at bottom):

getRank() is now public.

Differential Revision: D34833222

getRank() is now public. Differential Revision: [D34833222](https://our.internmc.facebook.com/intern/diff/D34833222/) [ghstack-poisoned]

facebook-github-bot · 2022-03-11T22:36:18Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/74127
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 30f79fe (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-xenial-py3.7-clang7-onnx / test (default, 2, 2, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-14T22:20:10.3244125Z AssertionError:

2022-03-14T22:20:10.3239583Z   File "/var/lib/jenkins/workspace/test/onnx/test_pytorch_onnx_onnxruntime.py", line 194, in run_model_test
2022-03-14T22:20:10.3240234Z     ort_compare_with_pytorch(ort_outs, output, rtol, atol)
2022-03-14T22:20:10.3240664Z   File "/var/lib/jenkins/workspace/test/onnx/test_pytorch_onnx_onnxruntime.py", line 137, in ort_compare_with_pytorch
2022-03-14T22:20:10.3241348Z     [np.testing.assert_allclose(out, ort_out, rtol=rtol, atol=atol) for out, ort_out in zip(outputs, ort_outs)]
2022-03-14T22:20:10.3241967Z   File "/var/lib/jenkins/workspace/test/onnx/test_pytorch_onnx_onnxruntime.py", line 137, in <listcomp>
2022-03-14T22:20:10.3242497Z     [np.testing.assert_allclose(out, ort_out, rtol=rtol, atol=atol) for out, ort_out in zip(outputs, ort_outs)]
2022-03-14T22:20:10.3242960Z   File "/opt/conda/lib/python3.7/site-packages/numpy/testing/_private/utils.py", line 1529, in assert_allclose
2022-03-14T22:20:10.3243263Z     verbose=verbose, header=header, equal_nan=equal_nan)
2022-03-14T22:20:10.3243652Z   File "/opt/conda/lib/python3.7/site-packages/numpy/testing/_private/utils.py", line 842, in assert_array_compare
2022-03-14T22:20:10.3243933Z     raise AssertionError(msg)
2022-03-14T22:20:10.3244125Z AssertionError: 
2022-03-14T22:20:10.3244362Z Not equal to tolerance rtol=0.001, atol=1e-07
2022-03-14T22:20:10.3244494Z 
2022-03-14T22:20:10.3244580Z Mismatched elements: 1 / 32 (3.12%)
2022-03-14T22:20:10.3244776Z Max absolute difference: 192
2022-03-14T22:20:10.3244970Z Max relative difference: 1.
2022-03-14T22:20:10.3245166Z  x: array([[  0,   0,   9,   0,   7,  39,   0,   0],
2022-03-14T22:20:10.3245342Z        [255, 128,  72, 148,   5, 132,   0,   0],
2022-03-14T22:20:10.3245521Z        [  0,   0,   0,   0,   4, 174,   0,   0],
2022-03-14T22:20:10.3245794Z        [  2, 128,  70,  88,   2,   0, 238, 176]], dtype=uint8)
2022-03-14T22:20:10.3246000Z  y: array([[  0,   0,   9,   0,   7,  39,   0,   0],

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

pytorch-bot · 2022-03-11T22:36:20Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/16f254fa6085e40471946f6ef42b05412af84884/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-binary-manywheel	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
windows-binary-libtorch-debug	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
windows-binary-libtorch-release	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
windows-binary-wheel	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`, `ciflow/trunk`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-bionic-rocm4.5-py3.7-distributed	`ciflow/all`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	🚫 skipped

getRank() is now public. Differential Revision: [D34833222](https://our.internmc.facebook.com/intern/diff/D34833222/) ghstack-source-id: 151192376 Pull Request resolved: #74127

getRank() is now public. Differential Revision: [D34833222](https://our.internmc.facebook.com/intern/diff/D34833222/) [ghstack-poisoned]

Pull Request resolved: #74127 getRank() is now public. ghstack-source-id: 151319258 Differential Revision: [D34833222](https://our.internmc.facebook.com/intern/diff/D34833222/)

rohan-varma · 2022-03-15T14:40:35Z

ONNX issue is unrelated.

Summary: Pull Request resolved: #74127 getRank() is now public. ghstack-source-id: 151319258 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D34833222 fbshipit-source-id: a846509e2d61dd9208706d471c7c83819ce24922

github-actions · 2022-03-15T15:02:21Z

Hey @rohan-varma.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

[Reducer] small fix

16f254f

getRank() is now public. Differential Revision: [D34833222](https://our.internmc.facebook.com/intern/diff/D34833222/) [ghstack-poisoned]

rohan-varma requested review from mrshenli, pritamdamania87 and zhaojuanmao as code owners March 11, 2022 22:36

rohan-varma requested review from H-Huang and mingzhe09088 as code owners March 11, 2022 22:36

pytorch-bot bot added the ciflow/default label Mar 11, 2022

facebook-github-bot added the cla signed label Mar 11, 2022

rohan-varma mentioned this pull request Mar 11, 2022

[ddp] parameter verification #74113

Closed

facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Mar 11, 2022

rohan-varma added a commit that referenced this pull request Mar 11, 2022

[Reducer] small fix

efbb1d1

getRank() is now public. Differential Revision: [D34833222](https://our.internmc.facebook.com/intern/diff/D34833222/) ghstack-source-id: 151192376 Pull Request resolved: #74127

zhaojuanmao approved these changes Mar 13, 2022

View reviewed changes

Update on "[Reducer] small fix"

30f79fe

getRank() is now public. Differential Revision: [D34833222](https://our.internmc.facebook.com/intern/diff/D34833222/) [ghstack-poisoned]

rohan-varma added a commit that referenced this pull request Mar 14, 2022

[Reducer] small fix

9ba6988

Pull Request resolved: #74127 getRank() is now public. ghstack-source-id: 151319258 Differential Revision: [D34833222](https://our.internmc.facebook.com/intern/diff/D34833222/)

pytorchmergebot closed this in 3b421af Mar 15, 2022

facebook-github-bot deleted the gh/rohan-varma/521/head branch March 19, 2022 14:17

WBobby mentioned this pull request Aug 17, 2022

Add ROCm5.2.3/AMDGPU support for PyTorch WBobby/pytorch#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Reducer] small fix #74127

[Reducer] small fix #74127

Uh oh!

rohan-varma commented Mar 11, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Mar 11, 2022 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 11, 2022

⚛️ CI Flow

Uh oh!

rohan-varma commented Mar 15, 2022

Uh oh!

github-actions bot commented Mar 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Reducer] small fix #74127

[Reducer] small fix #74127

Uh oh!

Conversation

rohan-varma commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

linux-xenial-py3.7-clang7-onnx / test (default, 2, 2, linux.2xlarge) (1/1)

Uh oh!

pytorch-bot bot commented Mar 11, 2022

⚛️ CI Flow

Uh oh!

rohan-varma commented Mar 15, 2022

Uh oh!

github-actions bot commented Mar 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rohan-varma commented Mar 11, 2022 •

edited

Loading

facebook-github-bot commented Mar 11, 2022 •

edited

Loading