Create method to map JIT module to (source, constant) and back. #74119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
facebook-github-bot
added
cla signed
oncall: jit
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 99be5b2 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34803945 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34803945 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34803945 |
zhxchen17
reviewed
Mar 14, 2022
test/cpp/jit/test_save_load.cpp
Outdated
Contributor
There was a problem hiding this comment.
nit: we don't need both namespace {} and static
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34803945 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34803945 |
…rch#74119) Summary: Pull Request resolved: pytorch#74119 implemented function to generate source as ExtraFilesMap and constants wrote function to construct jit module given (ivalue, source, constant) tripple. Test Plan: unittest Reviewed By: pavithranrao Differential Revision: D34803945 fbshipit-source-id: 90683da2a72708295189545a62520cd135608c2e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34803945 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Summary: Pull Request resolved: #74119 implemented function to generate source as ExtraFilesMap and constants wrote function to construct jit module given (ivalue, source, constant) tripple. Test Plan: unittest Reviewed By: pavithranrao Differential Revision: D34803945 fbshipit-source-id: 2edc798407fe68294cb4c3c7516f5bd143df88c3
Contributor
|
Hey @qihqi. |
qihqi
added
release notes: mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
implemented function to generate source as ExtraFilesMap and constants
wrote function to construct jit module given (ivalue, source,
constant) tripple.
Test Plan: unittest
Differential Revision: D34803945