[PyTorch] Add unit test for c10::Synchronized<T> #74110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this class was added, it's missing a unit test. @dbort first noticed it, so adding one in this commit. Differential Revision: [D34822911](https://our.internmc.facebook.com/intern/diff/D34822911/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5003172 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced Mar 11, 2022
Since this class was added, it's missing a unit test. dbort first noticed it, so adding one in this commit. Differential Revision: [D34822911](https://our.internmc.facebook.com/intern/diff/D34822911/) [ghstack-poisoned]
Since this class was added, it's missing a unit test. dbort first noticed it, so adding one in this commit. Differential Revision: [D34822911](https://our.internmc.facebook.com/intern/diff/D34822911/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Mar 11, 2022
Pull Request resolved: #74110 Since this class was added, it's missing a unit test. @dbort first noticed it, so adding one in this commit. ghstack-source-id: 151157422 Differential Revision: [D34822911](https://our.internmc.facebook.com/intern/diff/D34822911/)
dbort
approved these changes
Mar 11, 2022
| t.join(); | ||
| } | ||
|
|
||
| iv.withLock([](int& iv) { EXPECT_EQ(iv, NUM_LOOP_INCREMENTS * 10); }); |
Contributor
There was a problem hiding this comment.
Consider using threads.size() instead of 10
Since this class was added, it's missing a unit test. dbort first noticed it, so adding one in this commit. Differential Revision: [D34822911](https://our.internmc.facebook.com/intern/diff/D34822911/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Mar 16, 2022
Pull Request resolved: #74110 Since this class was added, it's missing a unit test. @dbort first noticed it, so adding one in this commit. ghstack-source-id: 151471746 Differential Revision: [D34822911](https://our.internmc.facebook.com/intern/diff/D34822911/)
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74110 Since this class was added, it's missing a unit test. dbort first noticed it, so adding one in this commit. ghstack-source-id: 151471746 Test Plan: `buck test //xplat/caffe2/c10:c10_test` Reviewed By: dbort Differential Revision: D34822911 fbshipit-source-id: 919a125081a2093d6f4e5a2cdb008145c05ec803
Contributor
|
Hey @dhruvbird. |
dhruvbird
added
release notes: cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Since this class was added, it's missing a unit test. @dbort first noticed it, so adding one in this commit.
Differential Revision: D34822911