[PyTorch] Use c10::Synchronized<T> in RWSafeLeftRightWrapper #74109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the title says - to prevent unintentional usage of the `data_` member without the lock held. Differential Revision: [D34822913](https://our.internmc.facebook.com/intern/diff/D34822913/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 36ffebe (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 11, 2022
As the title says - to prevent unintentional usage of the `data_` member without the lock held. Differential Revision: [D34822913](https://our.internmc.facebook.com/intern/diff/D34822913/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74109 As the title says - to prevent unintentional usage of the `data_` member without the lock held. ghstack-source-id: 151471742 Test Plan: Build using: ``` buck build -c pt.disable_per_op_profiling=0 -c pt.enable_record_kernel_dtype=1 --show-output xplat/caffe2/fb/model_tracer:model_tracer ``` Reviewed By: malfet Differential Revision: D34822913 fbshipit-source-id: 956fbe78956cf556fd6c8481b910acf557fbe608
dhruvbird
added
release notes: cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As the title says - to prevent unintentional usage of the
data_member without the lock held.Differential Revision: D34822913