[tensorexpr] Enabled aten::stack in the fuser pass with static shapes #74077

huiguoo · 2022-03-11T01:10:45Z

Stack from ghstack (oldest at bottom):

Differential Revision: D34808051

[ghstack-poisoned]

pytorch-bot · 2022-03-11T01:10:49Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/6577fe302816b3ecf0824491c6f690816305c7eb/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-binary-manywheel	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`, `ciflow/trunk`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
windows-binary-libtorch-debug	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
windows-binary-libtorch-release	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`, `ciflow/trunk`	✅ triggered
windows-binary-wheel	`ciflow/all`, `ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`, `ciflow/trunk`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-bionic-rocm4.5-py3.7-distributed	`ciflow/all`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	🚫 skipped

facebook-github-bot · 2022-03-11T01:10:51Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/74077
↩️ [fb-only] Re-run with SSH instructions
Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit 4657bc9 (more details on the Dr. CI page):

2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-29T17:55:46.0159648Z The PR is introduc...m to confirm whether this change is wanted or not.

2022-03-29T17:55:46.0147271Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> (str _0)
2022-03-29T17:55:46.0148823Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-03-29T17:55:46.0149674Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-03-29T17:55:46.0150961Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> (__torch__.torch.classes.profiling.SourceRef _0)
2022-03-29T17:55:46.0152727Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> (Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0)
2022-03-29T17:55:46.0153840Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-03-29T17:55:46.0154713Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-03-29T17:55:46.0155918Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-03-29T17:55:46.0157571Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> (__torch__.torch.classes.profiling.SourceStats[] _0)
2022-03-29T17:55:46.0158883Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (NoneType _0)
2022-03-29T17:55:46.0159648Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-03-29T17:55:46.0160268Z 
2022-03-29T17:55:46.0160402Z Broken ops: [
2022-03-29T17:55:46.0160974Z 	aten::histogramdd(Tensor self, int[] bins, float[]? range=None, Tensor? weight=None, bool density=False) -> (Tensor hist, Tensor[] bin_edges)
2022-03-29T17:55:46.0161531Z 	aten::histogramdd.int_bins(Tensor self, int bins, float[]? range=None, Tensor? weight=None, bool density=False) -> (Tensor hist, Tensor[] bin_edges)
2022-03-29T17:55:46.0162105Z 	aten::histogramdd.TensorList_bins(Tensor self, Tensor[] bins, float[]? range=None, Tensor? weight=None, bool density=False) -> (Tensor hist, Tensor[] bin_edges)
2022-03-29T17:55:46.0162524Z 	aten::_to_dense(Tensor self, int? dtype=None) -> (Tensor)
2022-03-29T17:55:46.0162746Z ]
2022-03-29T17:55:46.1319801Z + cleanup
2022-03-29T17:55:46.1320071Z + retcode=1
2022-03-29T17:55:46.1320240Z + set +x

1 failure not recognized by patterns:

Job	Step	Action
^{pull / linux-xenial-py3.7-clang7-asan / test (default, 2, 3, linux.2xlarge)}	^Test	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ghstack-source-id: 9040050 Pull Request resolved: #74077

huiguoo · 2022-03-11T01:11:47Z

@huiguoo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

navahgar · 2022-03-12T01:10:40Z

test/test_jit_fuser_te.py

                # FileCheck().check("FusedConcat").check_next("return").run(str(graph))

+    def test_stack(self):
+        # "aten::stack fusion is not enabled yet with dynamic shapes"


What is the reason for this restriction?

The shape computation formula for aten::stack in JIT is not added in this PR. Will do it in the next PR. It seems a bit compound to have both changes for static and dynamic shapes in one PR.

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

ghstack-source-id: 70ecf5e Pull Request resolved: #74077

huiguoo · 2022-03-14T22:26:29Z

@huiguoo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

navahgar

LGTM

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

ghstack-source-id: 18ff284 Pull Request resolved: #74077

huiguoo · 2022-03-22T00:18:37Z

@huiguoo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

huiguoo · 2022-03-25T18:26:16Z

@huiguoo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

ghstack-source-id: eb40904 Pull Request resolved: #74077

huiguoo · 2022-03-25T23:25:20Z

@huiguoo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

ghstack-source-id: 8b17371 Pull Request resolved: #74077

huiguoo · 2022-03-29T17:42:37Z

@huiguoo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…#74077) Summary: Pull Request resolved: #74077 Test Plan: Imported from OSS Reviewed By: gchanan Differential Revision: D34808051 Pulled By: huiguoo fbshipit-source-id: 213e2ffdf87fb1a74104037cea7ef25e4bfd4307

facebook-github-bot · 2022-03-31T04:04:44Z

This pull request has been reverted by 8f885d1c2362c3d709d4072c4f972a7fdd6256b6. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

…#74077) Summary: Pull Request resolved: #74077 Test Plan: Imported from OSS Reviewed By: gchanan Differential Revision: D34808051 Pulled By: huiguoo fbshipit-source-id: 213e2ffdf87fb1a74104037cea7ef25e4bfd4307 (cherry picked from commit ad9e848)

facebook-github-bot · 2022-03-31T04:25:58Z

This pull request has been reverted by 320e5a8. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

facebook-github-bot · 2022-04-05T00:55:01Z

This pull request has been reverted by 320e5a8. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

[tensorexpr] Enabled aten::stack in the fuser pass with static shapes

6577fe3

[ghstack-poisoned]

huiguoo mentioned this pull request Mar 11, 2022

[tensorexpr] Add support for aten::stack #73801

Closed

pytorch-bot bot added the ciflow/default label Mar 11, 2022

facebook-github-bot added the cla signed label Mar 11, 2022

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 11, 2022

huiguoo added a commit that referenced this pull request Mar 11, 2022

[tensorexpr] Enabled aten::stack in the fuser pass with static shapes

d54b4ef

ghstack-source-id: 9040050 Pull Request resolved: #74077

huiguoo requested a review from navahgar March 11, 2022 01:11

navahgar reviewed Mar 12, 2022

View reviewed changes

navahgar requested a review from eellison March 12, 2022 01:10

Update on "[tensorexpr] Enabled aten::stack in the fuser pass with st…

4694ca3

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

huiguoo added a commit that referenced this pull request Mar 14, 2022

[tensorexpr] Enabled aten::stack in the fuser pass with static shapes

9b2cf0d

ghstack-source-id: 70ecf5e Pull Request resolved: #74077

huiguoo requested a review from navahgar March 16, 2022 00:48

navahgar approved these changes Mar 16, 2022

View reviewed changes

Update on "[tensorexpr] Enabled aten::stack in the fuser pass with st…

5f0fe05

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

huiguoo added a commit that referenced this pull request Mar 22, 2022

[tensorexpr] Enabled aten::stack in the fuser pass with static shapes

99c24c7

ghstack-source-id: 18ff284 Pull Request resolved: #74077

suo removed the ciflow/default label Mar 22, 2022

Update on "[tensorexpr] Enabled aten::stack in the fuser pass with st…

9c75d3e

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

Update on "[tensorexpr] Enabled aten::stack in the fuser pass with st…

55ac18a

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

huiguoo added a commit that referenced this pull request Mar 25, 2022

[tensorexpr] Enabled aten::stack in the fuser pass with static shapes

7f3bc41

ghstack-source-id: eb40904 Pull Request resolved: #74077

Update on "[tensorexpr] Enabled aten::stack in the fuser pass with st…

4657bc9

…atic shapes" Differential Revision: [D34808051](https://our.internmc.facebook.com/intern/diff/D34808051) [ghstack-poisoned]

huiguoo added a commit that referenced this pull request Mar 29, 2022

[tensorexpr] Enabled aten::stack in the fuser pass with static shapes

f1e8815

ghstack-source-id: 8b17371 Pull Request resolved: #74077

pytorchmergebot closed this Mar 31, 2022

facebook-github-bot added the Reverted label Mar 31, 2022

facebook-github-bot deleted the gh/huiguoo/58/head branch April 30, 2022 14:17

WBobby mentioned this pull request Aug 17, 2022

Add ROCm5.2.3/AMDGPU support for PyTorch WBobby/pytorch#2

Closed

[tensorexpr] Enabled aten::stack in the fuser pass with static shapes #74077

[tensorexpr] Enabled aten::stack in the fuser pass with static shapes #74077

Uh oh!

Conversation

huiguoo commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 11, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

1 failure not recognized by patterns:

Uh oh!

huiguoo commented Mar 11, 2022

Uh oh!

navahgar Mar 12, 2022

Choose a reason for hiding this comment

Uh oh!

huiguoo Mar 14, 2022

Choose a reason for hiding this comment

Uh oh!

huiguoo commented Mar 14, 2022

Uh oh!

navahgar left a comment

Choose a reason for hiding this comment

Uh oh!

huiguoo commented Mar 22, 2022

Uh oh!

huiguoo commented Mar 25, 2022

Uh oh!

huiguoo commented Mar 25, 2022

Uh oh!

huiguoo commented Mar 29, 2022

Uh oh!

facebook-github-bot commented Mar 31, 2022

Uh oh!

facebook-github-bot commented Mar 31, 2022

Uh oh!

facebook-github-bot commented Apr 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

huiguoo commented Mar 11, 2022 •

edited

Loading

facebook-github-bot commented Mar 11, 2022 •

edited

Loading