Extend Graph Export to NNC, extend script to support CPU #74076
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 90b0540 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
facebook-github-bot
added
the
oncall: jit
davidberard98
approved these changes
Mar 11, 2022
Contributor
davidberard98
left a comment
davidberard98
left a comment
There was a problem hiding this comment.
Cool, thanks for adding the cpu timing!
Left a comment about whether we should print IR, otherwise looks good
| print(f" Graph {i}; baseline: {baseline:.2f} ms; nvfuser: {nvfuser:.2f} ms; improvement: {improvement:.2f}%") | ||
| except RuntimeError: | ||
| print(f" Graph {i} failed:", traceback.format_exc()) | ||
| print(f"Running Graph {ir}") |
Contributor
There was a problem hiding this comment.
nit - I thought it was nice having just the index, because it gets cluttered when we print the ir along with the performance results (especially with the nvfuser/torchbench results where there's ~2500 fusion groups). Plus it might be easier to export to csv if we're only printing indices.
But I'm fine with leaving in the IR if you think it's important
Contributor
|
@eellison Thanks for extending the script for NNC! Can you specify what output file it generates? I checked the PR out and tried it with a local test but did not see any outputs. Here's the log file for my local test: P486118155 |
Contributor
Author
|
@huiguoo it should have around the graph - I repro'd and got this working locally |
Contributor
|
also - I think time.perf_counter() returns seconds, while the cuda timer measures in milliseconds. Might be good to make them all use the same units. |
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` [ghstack-poisoned]
This was referenced Mar 16, 2022
Closed
Closed
added 2 commits
March 16, 2022 17:13
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` [ghstack-poisoned]
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` Differential Revision: [D34946883](https://our.internmc.facebook.com/intern/diff/D34946883) [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
added 2 commits
March 22, 2022 09:32
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` Differential Revision: [D34946883](https://our.internmc.facebook.com/intern/diff/D34946883) [ghstack-poisoned]
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` Differential Revision: [D34946883](https://our.internmc.facebook.com/intern/diff/D34946883) [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` Differential Revision: [D34946883](https://our.internmc.facebook.com/intern/diff/D34946883) [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` Differential Revision: [D34946883](https://our.internmc.facebook.com/intern/diff/D34946883) [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` Differential Revision: [D34946883](https://our.internmc.facebook.com/intern/diff/D34946883) [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` Differential Revision: [D34946883](https://our.internmc.facebook.com/intern/diff/D34946883) [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
Summary: Pull Request resolved: #74076 Extends the repro script to cpu and NNC. As in file: Usage: ``` 1. Run your script and pipe into a log file PYTORCH_JIT_LOG_LEVEL=">>tensorexpr_fuser" python3 my_test.py &> log.txt 2. Run log_extract: log_extract.py log.txt --baseline --nnc ``` Test Plan: Imported from OSS Reviewed By: gchanan Differential Revision: D34946883 Pulled By: eellison fbshipit-source-id: 644012dbbca0b490820ef83e761c06b0dd009e52
Contributor
|
Hey @eellison. |
NesrineMHB
pushed a commit
to NesrineMHB/pytorch
that referenced
this pull request
Apr 8, 2022
ghstack-source-id: 2551ab5 Pull Request resolved: pytorch/pytorch#74076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Extends the repro script to cpu and NNC. As in file:
Usage:
Differential Revision: D34946883