[PyTorch] Add unit test for c10::Synchronized<T> #74062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this class was added, it's missing a unit test. @dbort first noticed it, so adding one in this commit. Differential Revision: [D34800969](https://our.internmc.facebook.com/intern/diff/D34800969/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 4538391 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 Lint / clang-format |
Run clang-format | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
This was referenced Mar 10, 2022
dhruvbird
added a commit
that referenced
this pull request
Mar 10, 2022
Since this class was added, it's missing a unit test. dbort first noticed it, so adding one in this commit. Differential Revision: [D34800969](https://our.internmc.facebook.com/intern/diff/D34800969/) ghstack-source-id: 151080043 Pull Request resolved: #74062
dbort
reviewed
Mar 11, 2022
Contributor
dbort
left a comment
dbort
left a comment
There was a problem hiding this comment.
Thank you so much for adding this! Looks great.
Please take a look at the clang-tidy and clang-format warnings/errors on internal CI.
c10/test/util/Synchronized_test.cpp
Outdated
Comment on lines
1
to
2
| #include "c10/util/Synchronized.h" | ||
| #include <c10/util/Synchronized.h> |
Since this class was added, it's missing a unit test. dbort first noticed it, so adding one in this commit. Differential Revision: [D34800969](https://our.internmc.facebook.com/intern/diff/D34800969/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Mar 11, 2022
Pull Request resolved: #74062 Since this class was added, it's missing a unit test. @dbort first noticed it, so adding one in this commit. ghstack-source-id: 151114689 Differential Revision: [D34800969](https://our.internmc.facebook.com/intern/diff/D34800969/)
dbort
approved these changes
Mar 11, 2022
Since this class was added, it's missing a unit test. dbort first noticed it, so adding one in this commit. Differential Revision: [D34800969](https://our.internmc.facebook.com/intern/diff/D34800969/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Mar 11, 2022
Pull Request resolved: #74062 Since this class was added, it's missing a unit test. @dbort first noticed it, so adding one in this commit. ghstack-source-id: 151122696 Differential Revision: [D34800969](https://our.internmc.facebook.com/intern/diff/D34800969/)
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
Summary: Pull Request resolved: #74062 Since this class was added, it's missing a unit test. dbort first noticed it, so adding one in this commit. ghstack-source-id: 151122696 Test Plan: `buck test //xplat/caffe2/c10:c10_test` Reviewed By: dbort Differential Revision: D34800969 fbshipit-source-id: e665ab0df2faf505536bf27bdf29fcd3e70fe699
Contributor
|
Hey @dhruvbird. |
Contributor
|
Why this change was landed when it clearly broke Windows builds and clang-format? |
Contributor
|
This pull request has been reverted by 4adfe06. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Contributor
|
This pull request has been reverted by 4adfe06. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Since this class was added, it's missing a unit test. @dbort first noticed it, so adding one in this commit.
Differential Revision: D34800969