Fix test_reduce_add_coalesced failure
#74027
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanYashchuk
added
module: multi-gpu
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c8a6c6b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
reviewed
Mar 10, 2022
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
pmeier
approved these changes
Mar 10, 2022
Collaborator
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
Change looks good. Thanks @IvanYashchuk! Unfortunately, I have no idea how to verify this apart from doing it locally since the test seems to not be run in CI.
mruberry
approved these changes
Mar 14, 2022
Collaborator
mruberry
left a comment
mruberry
left a comment
There was a problem hiding this comment.
Stamped! Thanks @IvanYashchuk
Contributor
|
@mruberry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Summary: Recent change (#69751) introduced the requirement of using `.coalesce()` explicitly in the tests. Unfortunately, not all tests are run in the current CI configuration and one test failure slipped through. Fixes #74015. Pull Request resolved: #74027 Reviewed By: samdow Differential Revision: D34858112 Pulled By: mruberry fbshipit-source-id: 8904fac5e2b5335684a21f95a22646469478eb81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent change (#69751) introduced the requirement of using
.coalesce()explicitly in the tests. Unfortunately, not all tests are run in the current CI configuration and one test failure slipped through.Fixes #74015.