[BE Hackathon][DataPipe] Automatically generate datapipe.pyi via CMake #73991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1fb559a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NivekT
changed the title
NivekT
added
module: data
albanD
approved these changes
Mar 10, 2022
…yi via CMake" Automatically generate `datapipe.pyi` via CMake Since it will be automatically generated, I believe we should remove the output file from git VCS (like other generated .pyi file). [ghstack-poisoned]
…yi via CMake" Automatically generate `datapipe.pyi` via CMake Since it will be automatically generated, I believe we should remove the output file from git VCS (like other generated .pyi file). [ghstack-poisoned]
Contributor
Author
I removed a dependency and I think it should work fine now |
…yi via CMake" Automatically generate `datapipe.pyi` via CMake Since it will be automatically generated, I believe we should remove the output file from git VCS (like other generated .pyi file). [ghstack-poisoned]
Contributor
Author
|
@ejguan @albanD Should I be removing the generated .pyi file from git VCS? Here is the trade off (should only impact PyTorch developers):
I am currently keeping the .pyi file in Git but adding it to |
Contributor
Author
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…yi via CMake" Automatically generate `datapipe.pyi` via CMake and removing the generated .pyi file from Git. Users should have the .pyi file locally after building for the first time. I will also be adding an internal equivalent diff for buck. Differential Revision: [D34868001](https://our.internmc.facebook.com/intern/diff/D34868001) [ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…yi via CMake" Automatically generate `datapipe.pyi` via CMake and removing the generated .pyi file from Git. Users should have the .pyi file locally after building for the first time. I will also be adding an internal equivalent diff for buck. Differential Revision: [D34868001](https://our.internmc.facebook.com/intern/diff/D34868001) [ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
#73991) Summary: Pull Request resolved: #73991 Automatically generate `datapipe.pyi` via CMake and removing the generated .pyi file from Git. Users should have the .pyi file locally after building for the first time. I will also be adding an internal equivalent diff for buck. Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D34868001 Pulled By: NivekT fbshipit-source-id: 448c92da659d6b4c5f686407d3723933c266c74f
Contributor
|
Hey @NivekT. |
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…p.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…p.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…p.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…p.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 16, 2022
…p.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 21, 2022
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
NivekT
added a commit
to meta-pytorch/data
that referenced
this pull request
Mar 21, 2022
…p.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
facebook-github-bot
pushed a commit
to meta-pytorch/data
that referenced
this pull request
Mar 21, 2022
Summary: Pull Request resolved: #290 This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D34939044 Pulled By: NivekT fbshipit-source-id: fa4cdcc01274ea8728b38b13a1410556ef85d8cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Automatically generate
datapipe.pyivia CMake and removing the generated .pyi file from Git. Users should have the .pyi file locally after building for the first time.I will also be adding an internal equivalent diff for buck.
Differential Revision: D34868001