(torchx/elastic) honor NCCL_ASYNC_ERROR_HANDLING set from the env var #73982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiukchung
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5b14ea7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34765786 |
kiukchung
force-pushed
the
export-D34765786
branch
from
e3564f3 to
ef01899
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34765786 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34765786 |
kiukchung
force-pushed
the
export-D34765786
branch
from
ef01899 to
6ef997e
Compare
…pytorch#73982) Summary: Pull Request resolved: pytorch#73982 Currently there is no way for users using torchelastic to override NCCL_ASYNC_ERROR_HANDLING=0. This PR enables this. Test Plan: Added unittests Manual testing ``` $ torchx run fb.dist.ddp -- --img torchx_examples -m print_env_vars.py --env NCCL_ASYNC_ERROR_HANDLING=0 ``` Validated the NCCL_ASYNC_ERROR_HANDLING in the process running `print_env_vars.py` is indeed `0`. Reviewed By: mannatsingh, aivanou Differential Revision: D34765786 fbshipit-source-id: f4cb5623aa49d9d40d509c9c01a293276c7b8ee6
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34765786 |
kiukchung
force-pushed
the
export-D34765786
branch
from
6ef997e to
5b14ea7
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
…#73982) Summary: Pull Request resolved: #73982 Currently there is no way for users using torchelastic to override NCCL_ASYNC_ERROR_HANDLING=0. This PR enables this. Test Plan: Added unittests Manual testing ``` $ torchx run fb.dist.ddp -- --img torchx_examples -m print_env_vars.py --env NCCL_ASYNC_ERROR_HANDLING=0 ``` Validated the NCCL_ASYNC_ERROR_HANDLING in the process running `print_env_vars.py` is indeed `0`. Reviewed By: mannatsingh, aivanou Differential Revision: D34765786 fbshipit-source-id: 3f9f6d3b61e7d265adf689d387e020ab534c9259
Contributor
|
Hey @kiukchung. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D34765786