Refactor error input tests in test_torch.py to OpInfos #73981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 80f07a6 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
desertfire
force-pushed
the
error_input_tests_to_opinfo
branch
from
6209588 to
51fd8d4
Compare
mruberry
reviewed
Mar 14, 2022
mruberry
reviewed
Mar 14, 2022
| error_type=RuntimeError, | ||
| error_regex='unsupported operation') | ||
|
|
||
| yield ErrorInput(SampleInput(src, args=(0, ind,), kwargs=dict(out=src)), |
Collaborator
There was a problem hiding this comment.
I suppose it's OK for error inputs to share data because they're just supposed to throw an error
mruberry
approved these changes
Mar 14, 2022
Collaborator
mruberry
left a comment
mruberry
left a comment
There was a problem hiding this comment.
Cool! Thanks @saketh-are!
Contributor
|
@saketh-are has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
Summary: This PR ports several tests in `test/test_torch.py` over to OpInfo ErrorInputs. Some tests commented "convert to ErrorInputs" still remain in `test_torch.py`. They fall under two categories: - Memory overlap tests which specifically test the in-place version of an operator (e.g. [this test](https://github.com/pytorch/pytorch/blob/424a054d53e5f3229411532fb69fae276b29dcb2/test/test_torch.py#L3788) for index_add_). - Tests with non-trivial behavior calling `torch.cuda.synchronize()` after calling the operator being tested (e.g. [this test](https://github.com/pytorch/pytorch/blob/424a054d53e5f3229411532fb69fae276b29dcb2/test/test_torch.py#L4948) for torch.multinomial). Pull Request resolved: #73981 Reviewed By: qihqi Differential Revision: D35016669 Pulled By: saketh-are fbshipit-source-id: bc0016d2b2bfb566a9dfef81ecf44e0adb9e4b14
Contributor
|
Hey @saketh-are. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: This PR ports several tests in `test/test_torch.py` over to OpInfo ErrorInputs. Some tests commented "convert to ErrorInputs" still remain in `test_torch.py`. They fall under two categories: - Memory overlap tests which specifically test the in-place version of an operator (e.g. [this test](https://github.com/pytorch/pytorch/blob/424a054d53e5f3229411532fb69fae276b29dcb2/test/test_torch.py#L3788) for index_add_). - Tests with non-trivial behavior calling `torch.cuda.synchronize()` after calling the operator being tested (e.g. [this test](https://github.com/pytorch/pytorch/blob/424a054d53e5f3229411532fb69fae276b29dcb2/test/test_torch.py#L4948) for torch.multinomial). Pull Request resolved: #73981 Reviewed By: qihqi Differential Revision: D35016669 Pulled By: saketh-are fbshipit-source-id: bc0016d2b2bfb566a9dfef81ecf44e0adb9e4b14 (cherry picked from commit 99bcbdb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports several tests in
test/test_torch.pyover to OpInfo ErrorInputs.Some tests commented "convert to ErrorInputs" still remain in
test_torch.py. They fall under two categories:torch.cuda.synchronize()after calling the operator being tested (e.g. this test for torch.multinomial).